You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org> on 2017/06/08 22:10:23 UTC
[Impala-ASF-CR] IMPALA-5469: Fix exception when processing catalog update
Taras Bobrovytsky has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7121
Change subject: IMPALA-5469: Fix exception when processing catalog update
......................................................................
IMPALA-5469: Fix exception when processing catalog update
In IMPALA-5355 patch, a regression was introduced where we end up
calling addCatalogObject on a CATALOG object type in the second pass
over the catalog objects because the CATALOG object is not considered
a top level object.
The issue is fixed by updating the top level objects in the first pass
and updating the non top level objects and the catalog object in the
second pass.
Testing:
- Verified by manually running "invalidate metadata" and checking that
there is no exception in the impalad.INFO log file.
- No new tests were added because it is difficult and excessive to
reproduce the issue in a test.
Change-Id: I7b8e7db2c679ea9bffd8863a3367aa3b94e4e1ed
---
M fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java
1 file changed, 9 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/7121/1
--
To view, visit http://gerrit.cloudera.org:8080/7121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7b8e7db2c679ea9bffd8863a3367aa3b94e4e1ed
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
[Impala-ASF-CR] IMPALA-5469: Fix exception when processing catalog update
Posted by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org>.
Taras Bobrovytsky has uploaded a new patch set (#2).
Change subject: IMPALA-5469: Fix exception when processing catalog update
......................................................................
IMPALA-5469: Fix exception when processing catalog update
In IMPALA-5355 patch, a regression was introduced where we end up
calling addCatalogObject on a CATALOG object type in the second pass
over the catalog objects because the CATALOG object is not considered
a top level object.
The issue is fixed by updating the top level objects in the first pass
and updating the non top level objects and the catalog object in the
second pass.
Testing:
- Verified by manually running "invalidate metadata" and checking that
there is no exception in the impalad.INFO log file.
- No new tests were added because it is difficult and excessive to
reproduce the issue in a test.
Change-Id: I7b8e7db2c679ea9bffd8863a3367aa3b94e4e1ed
---
M fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java
1 file changed, 9 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/7121/2
--
To view, visit http://gerrit.cloudera.org:8080/7121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7b8e7db2c679ea9bffd8863a3367aa3b94e4e1ed
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
[Impala-ASF-CR] IMPALA-5469: Fix exception when processing catalog update
Posted by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org>.
Hello Dimitris Tsirogiannis, Alex Behm,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7121
to look at the new patch set (#2).
Change subject: IMPALA-5469: Fix exception when processing catalog update
......................................................................
IMPALA-5469: Fix exception when processing catalog update
In IMPALA-5355 patch, a regression was introduced where we end up
calling addCatalogObject on a CATALOG object type in the second pass
over the catalog objects because the CATALOG object is not considered
a top level object.
The issue is fixed by updating the top level objects in the first pass
and updating the non top level objects and the catalog object in the
second pass.
Testing:
- Verified by manually running "invalidate metadata" and checking that
there is no exception in the impalad.INFO log file.
- No new tests were added because it is difficult and excessive to
reproduce the issue in a test.
Change-Id: I7b8e7db2c679ea9bffd8863a3367aa3b94e4e1ed
---
M fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java
1 file changed, 9 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/7121/2
--
To view, visit http://gerrit.cloudera.org:8080/7121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7b8e7db2c679ea9bffd8863a3367aa3b94e4e1ed
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
[Impala-ASF-CR] IMPALA-5469: Fix exception when processing catalog update
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5469: Fix exception when processing catalog update
......................................................................
Patch Set 2:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/709/
--
To view, visit http://gerrit.cloudera.org:8080/7121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b8e7db2c679ea9bffd8863a3367aa3b94e4e1ed
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5469: Fix exception when processing catalog update
Posted by "Dimitris Tsirogiannis (Code Review)" <ge...@cloudera.org>.
Dimitris Tsirogiannis has posted comments on this change.
Change subject: IMPALA-5469: Fix exception when processing catalog update
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b8e7db2c679ea9bffd8863a3367aa3b94e4e1ed
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5469: Fix exception when processing catalog update
Posted by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org>.
Taras Bobrovytsky has posted comments on this change.
Change subject: IMPALA-5469: Fix exception when processing catalog update
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7121/1/fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java
File fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java:
Line 147: long newCatalogVersion = lastSyncedCatalogVersion_;
> move right before the second loop where this might be changed
Done
--
To view, visit http://gerrit.cloudera.org:8080/7121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b8e7db2c679ea9bffd8863a3367aa3b94e4e1ed
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5469: Fix exception when processing catalog update
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5469: Fix exception when processing catalog update
......................................................................
IMPALA-5469: Fix exception when processing catalog update
In IMPALA-5355 patch, a regression was introduced where we end up
calling addCatalogObject on a CATALOG object type in the second pass
over the catalog objects because the CATALOG object is not considered
a top level object.
The issue is fixed by updating the top level objects in the first pass
and updating the non top level objects and the catalog object in the
second pass.
Testing:
- Verified by manually running "invalidate metadata" and checking that
there is no exception in the impalad.INFO log file.
- No new tests were added because it is difficult and excessive to
reproduce the issue in a test.
Change-Id: I7b8e7db2c679ea9bffd8863a3367aa3b94e4e1ed
Reviewed-on: http://gerrit.cloudera.org:8080/7121
Reviewed-by: Taras Bobrovytsky <tb...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java
1 file changed, 9 insertions(+), 6 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Taras Bobrovytsky: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/7121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7b8e7db2c679ea9bffd8863a3367aa3b94e4e1ed
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
[Impala-ASF-CR] IMPALA-5469: Fix exception when processing catalog update
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5469: Fix exception when processing catalog update
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b8e7db2c679ea9bffd8863a3367aa3b94e4e1ed
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5469: Fix exception when processing catalog update
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-5469: Fix exception when processing catalog update
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7121/1/fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java
File fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java:
Line 147: long newCatalogVersion = lastSyncedCatalogVersion_;
move right before the second loop where this might be changed
--
To view, visit http://gerrit.cloudera.org:8080/7121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b8e7db2c679ea9bffd8863a3367aa3b94e4e1ed
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5469: Fix exception when processing catalog update
Posted by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org>.
Taras Bobrovytsky has posted comments on this change.
Change subject: IMPALA-5469: Fix exception when processing catalog update
......................................................................
Patch Set 2: Code-Review+2
Forwarding the +2
--
To view, visit http://gerrit.cloudera.org:8080/7121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b8e7db2c679ea9bffd8863a3367aa3b94e4e1ed
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-HasComments: No