You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2015/10/15 20:02:24 UTC
Review Request 39347: Add stout wrappers for toggling NOSIGPIPE on
file descriptors.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39347/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Bugs: MESOS-2079
https://issues.apache.org/jira/browse/MESOS-2079
Repository: mesos
Description
-------
Add stout wrappers for toggling NOSIGPIPE on file descriptors.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/README.md d7596e58e67699c1bc9c28da841b89ccd26f3a34
3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fcntl.hpp a9cb07ecd16f363cf2f77bc867277c737adfb68b
3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/fcntl.hpp 0bad61561ae25adb7ff6d731452577133688f8d4
Diff: https://reviews.apache.org/r/39347/diff/
Testing
-------
OS X and CentOS 6
make && make check
Thanks,
James Peach
Re: Review Request 39347: Add stout wrappers for toggling NOSIGPIPE
on file descriptors.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39347/#review102882
-----------------------------------------------------------
Ship it!
Ship It!
- haosdent huang
On Oct. 15, 2015, 6:02 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39347/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2015, 6:02 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-2079
> https://issues.apache.org/jira/browse/MESOS-2079
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add stout wrappers for toggling NOSIGPIPE on file descriptors.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/README.md d7596e58e67699c1bc9c28da841b89ccd26f3a34
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fcntl.hpp a9cb07ecd16f363cf2f77bc867277c737adfb68b
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/fcntl.hpp 0bad61561ae25adb7ff6d731452577133688f8d4
>
> Diff: https://reviews.apache.org/r/39347/diff/
>
>
> Testing
> -------
>
> OS X and CentOS 6
> make && make check
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 39347: Add stout wrappers for toggling NOSIGPIPE
on file descriptors.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39347/#review102928
-----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fcntl.hpp (line 102)
<https://reviews.apache.org/r/39347/#comment160762>
Needs a period (or just remove the comment).
- Neil Conway
On Oct. 15, 2015, 6:02 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39347/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2015, 6:02 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-2079
> https://issues.apache.org/jira/browse/MESOS-2079
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add stout wrappers for toggling NOSIGPIPE on file descriptors.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/README.md d7596e58e67699c1bc9c28da841b89ccd26f3a34
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fcntl.hpp a9cb07ecd16f363cf2f77bc867277c737adfb68b
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/fcntl.hpp 0bad61561ae25adb7ff6d731452577133688f8d4
>
> Diff: https://reviews.apache.org/r/39347/diff/
>
>
> Testing
> -------
>
> OS X and CentOS 6
> make && make check
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 39347: Add stout wrappers for toggling NOSIGPIPE
on file descriptors.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39347/#review102883
-----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fcntl.hpp (line 103)
<https://reviews.apache.org/r/39347/#comment160694>
Should we split into two function, one for enable, another one for disable. Because "nosigpipe" for enable looks a bit confuse.
- haosdent huang
On Oct. 15, 2015, 6:02 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39347/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2015, 6:02 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-2079
> https://issues.apache.org/jira/browse/MESOS-2079
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add stout wrappers for toggling NOSIGPIPE on file descriptors.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/README.md d7596e58e67699c1bc9c28da841b89ccd26f3a34
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fcntl.hpp a9cb07ecd16f363cf2f77bc867277c737adfb68b
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/fcntl.hpp 0bad61561ae25adb7ff6d731452577133688f8d4
>
> Diff: https://reviews.apache.org/r/39347/diff/
>
>
> Testing
> -------
>
> OS X and CentOS 6
> make && make check
>
>
> Thanks,
>
> James Peach
>
>