You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/02/19 01:10:40 UTC

Review Request 18249: Removed 'using namespace process' from header files.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18249/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.


Bugs: MESOS-1015
    https://issues.apache.org/jira/browse/MESOS-1015


Repository: mesos-git


Description
-------

See summary


Diffs
-----

  src/master/hierarchical_allocator_process.hpp 96b6ad569ea3758e4d078c6b2d60da4ea4fe8693 
  src/master/http.cpp 966eed6d8340038265ef799f1b6149502ccc606e 
  src/master/master.hpp 737bd8b5a1cd88a98a7f094795c50547079921ba 
  src/master/master.cpp a4e1b1f7327f01eb16f14c3fa08fc7a62048d36c 
  src/slave/cgroups_isolator.hpp 1a66dc630f0857db48b7cfb316fbbb15518fcec2 
  src/slave/cgroups_isolator.cpp ef7dd682e5462d0158d6ea6654246d77000e9778 
  src/slave/http.cpp c4f598faf6807214608cc89a6d9cf665133f95f3 
  src/slave/process_isolator.hpp bc52f33d8e83fe026be712c8b15e689eb23dd65c 
  src/slave/slave.hpp 2ddadb411f8b2f91a4a5038664f424d4eadfbb87 
  src/slave/slave.cpp 213df86084e51ab8407c6f2c2bd24ba718560faa 
  src/slave/status_update_manager.hpp 06ea4659cdd24cb1b82f389f404566ba14a663fb 
  src/slave/status_update_manager.cpp 03f5eafefd6ed748bfd4511d654c23c7b460db66 

Diff: https://reviews.apache.org/r/18249/diff/


Testing
-------

no functional change expected.

built. ran make check.


Thanks,

Dominic Hamon


Re: Review Request 18249: Removed 'using namespace process' from header files.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18249/#review35220
-----------------------------------------------------------


This patch needs a rebase to apply correctly:

error: patch failed: src/master/master.hpp:489
error: src/master/master.hpp: patch does not apply
error: src/slave/cgroups_isolator.hpp: does not exist in index
error: src/slave/cgroups_isolator.cpp: does not exist in index
error: src/slave/process_isolator.hpp: does not exist in index
error: patch failed: src/slave/slave.hpp:260
error: src/slave/slave.hpp: patch does not apply
error: patch failed: src/slave/slave.cpp:60
error: src/slave/slave.cpp: patch does not apply
Failed to apply patch

- Ben Mahler


On Feb. 19, 2014, 6:29 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18249/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2014, 6:29 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-1015
>     https://issues.apache.org/jira/browse/MESOS-1015
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary
> 
> 
> Diffs
> -----
> 
>   src/master/hierarchical_allocator_process.hpp 96b6ad569ea3758e4d078c6b2d60da4ea4fe8693 
>   src/master/http.cpp 966eed6d8340038265ef799f1b6149502ccc606e 
>   src/master/master.hpp 737bd8b5a1cd88a98a7f094795c50547079921ba 
>   src/master/master.cpp a4e1b1f7327f01eb16f14c3fa08fc7a62048d36c 
>   src/slave/cgroups_isolator.hpp 1a66dc630f0857db48b7cfb316fbbb15518fcec2 
>   src/slave/cgroups_isolator.cpp ef7dd682e5462d0158d6ea6654246d77000e9778 
>   src/slave/http.cpp c4f598faf6807214608cc89a6d9cf665133f95f3 
>   src/slave/process_isolator.hpp bc52f33d8e83fe026be712c8b15e689eb23dd65c 
>   src/slave/slave.hpp 2ddadb411f8b2f91a4a5038664f424d4eadfbb87 
>   src/slave/slave.cpp 213df86084e51ab8407c6f2c2bd24ba718560faa 
>   src/slave/status_update_manager.hpp 06ea4659cdd24cb1b82f389f404566ba14a663fb 
>   src/slave/status_update_manager.cpp 03f5eafefd6ed748bfd4511d654c23c7b460db66 
> 
> Diff: https://reviews.apache.org/r/18249/diff/
> 
> 
> Testing
> -------
> 
> no functional change expected.
> 
> built. ran make check.
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Re: Review Request 18249: Removed 'using namespace process' from header files.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18249/#review35349
-----------------------------------------------------------

Ship it!


Some trivial comments below, I'll do these for you when I pull down the patch!


src/master/http.cpp
<https://reviews.apache.org/r/18249/#comment65813>

    Please end with a period.



src/master/http.cpp
<https://reviews.apache.org/r/18249/#comment65814>

    Please end with a period.



src/slave/http.cpp
<https://reviews.apache.org/r/18249/#comment65815>

    Please end with a period.



src/slave/http.cpp
<https://reviews.apache.org/r/18249/#comment65816>

    Please end with a period.


- Ben Mahler


On Feb. 22, 2014, 1:22 a.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18249/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2014, 1:22 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-1015
>     https://issues.apache.org/jira/browse/MESOS-1015
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary
> 
> 
> Diffs
> -----
> 
>   src/master/hierarchical_allocator_process.hpp 96b6ad569ea3758e4d078c6b2d60da4ea4fe8693 
>   src/master/http.cpp 6654cac1b5e33f548a555ee516b3823dfb2f854e 
>   src/master/master.hpp 768dc3d165510d9e65e4b44075256b2805fde18c 
>   src/master/master.cpp de40884f873656cf91566ef49736cb8dda1300d8 
>   src/slave/http.cpp 7ed9abe704b852c0237886ad59ff94b31ac4fb24 
>   src/slave/slave.hpp d82d4e9547fc8c44f2210e1fafec766c381ab35c 
>   src/slave/slave.cpp 7ad823244eb8e9a2bc3899bdf728a5faed4eafbd 
>   src/slave/status_update_manager.hpp d29e269b00de0fc63d6281976f5efe1218ba9ba9 
>   src/slave/status_update_manager.cpp a88bb183b5122ff5adc59a0e6e697f7f9b2a3945 
> 
> Diff: https://reviews.apache.org/r/18249/diff/
> 
> 
> Testing
> -------
> 
> no functional change expected.
> 
> built. ran make check.
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Re: Review Request 18249: Removed 'using namespace process' from header files.

Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18249/
-----------------------------------------------------------

(Updated Feb. 21, 2014, 5:22 p.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.


Bugs: MESOS-1015
    https://issues.apache.org/jira/browse/MESOS-1015


Repository: mesos-git


Description
-------

See summary


Diffs (updated)
-----

  src/master/hierarchical_allocator_process.hpp 96b6ad569ea3758e4d078c6b2d60da4ea4fe8693 
  src/master/http.cpp 6654cac1b5e33f548a555ee516b3823dfb2f854e 
  src/master/master.hpp 768dc3d165510d9e65e4b44075256b2805fde18c 
  src/master/master.cpp de40884f873656cf91566ef49736cb8dda1300d8 
  src/slave/http.cpp 7ed9abe704b852c0237886ad59ff94b31ac4fb24 
  src/slave/slave.hpp d82d4e9547fc8c44f2210e1fafec766c381ab35c 
  src/slave/slave.cpp 7ad823244eb8e9a2bc3899bdf728a5faed4eafbd 
  src/slave/status_update_manager.hpp d29e269b00de0fc63d6281976f5efe1218ba9ba9 
  src/slave/status_update_manager.cpp a88bb183b5122ff5adc59a0e6e697f7f9b2a3945 

Diff: https://reviews.apache.org/r/18249/diff/


Testing
-------

no functional change expected.

built. ran make check.


Thanks,

Dominic Hamon


Re: Review Request 18249: Removed 'using namespace process' from header files.

Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18249/
-----------------------------------------------------------

(Updated Feb. 19, 2014, 10:29 a.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.


Bugs: MESOS-1015
    https://issues.apache.org/jira/browse/MESOS-1015


Repository: mesos-git


Description
-------

See summary


Diffs
-----

  src/master/hierarchical_allocator_process.hpp 96b6ad569ea3758e4d078c6b2d60da4ea4fe8693 
  src/master/http.cpp 966eed6d8340038265ef799f1b6149502ccc606e 
  src/master/master.hpp 737bd8b5a1cd88a98a7f094795c50547079921ba 
  src/master/master.cpp a4e1b1f7327f01eb16f14c3fa08fc7a62048d36c 
  src/slave/cgroups_isolator.hpp 1a66dc630f0857db48b7cfb316fbbb15518fcec2 
  src/slave/cgroups_isolator.cpp ef7dd682e5462d0158d6ea6654246d77000e9778 
  src/slave/http.cpp c4f598faf6807214608cc89a6d9cf665133f95f3 
  src/slave/process_isolator.hpp bc52f33d8e83fe026be712c8b15e689eb23dd65c 
  src/slave/slave.hpp 2ddadb411f8b2f91a4a5038664f424d4eadfbb87 
  src/slave/slave.cpp 213df86084e51ab8407c6f2c2bd24ba718560faa 
  src/slave/status_update_manager.hpp 06ea4659cdd24cb1b82f389f404566ba14a663fb 
  src/slave/status_update_manager.cpp 03f5eafefd6ed748bfd4511d654c23c7b460db66 

Diff: https://reviews.apache.org/r/18249/diff/


Testing
-------

no functional change expected.

built. ran make check.


Thanks,

Dominic Hamon


Re: Review Request 18249: Removed 'using namespace process' from header files.

Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18249/#review34818
-----------------------------------------------------------



src/master/http.cpp
<https://reviews.apache.org/r/18249/#comment65176>

    Fixed - added comment.


- Dominic Hamon


On Feb. 18, 2014, 4:45 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18249/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2014, 4:45 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-1015
>     https://issues.apache.org/jira/browse/MESOS-1015
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary
> 
> 
> Diffs
> -----
> 
>   src/master/hierarchical_allocator_process.hpp 96b6ad569ea3758e4d078c6b2d60da4ea4fe8693 
>   src/master/http.cpp 966eed6d8340038265ef799f1b6149502ccc606e 
>   src/master/master.hpp 737bd8b5a1cd88a98a7f094795c50547079921ba 
>   src/master/master.cpp a4e1b1f7327f01eb16f14c3fa08fc7a62048d36c 
>   src/slave/cgroups_isolator.hpp 1a66dc630f0857db48b7cfb316fbbb15518fcec2 
>   src/slave/cgroups_isolator.cpp ef7dd682e5462d0158d6ea6654246d77000e9778 
>   src/slave/http.cpp c4f598faf6807214608cc89a6d9cf665133f95f3 
>   src/slave/process_isolator.hpp bc52f33d8e83fe026be712c8b15e689eb23dd65c 
>   src/slave/slave.hpp 2ddadb411f8b2f91a4a5038664f424d4eadfbb87 
>   src/slave/slave.cpp 213df86084e51ab8407c6f2c2bd24ba718560faa 
>   src/slave/status_update_manager.hpp 06ea4659cdd24cb1b82f389f404566ba14a663fb 
>   src/slave/status_update_manager.cpp 03f5eafefd6ed748bfd4511d654c23c7b460db66 
> 
> Diff: https://reviews.apache.org/r/18249/diff/
> 
> 
> Testing
> -------
> 
> no functional change expected.
> 
> built. ran make check.
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Re: Review Request 18249: Removed 'using namespace process' from header files.

Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18249/
-----------------------------------------------------------

(Updated Feb. 18, 2014, 4:45 p.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.


Bugs: MESOS-1015
    https://issues.apache.org/jira/browse/MESOS-1015


Repository: mesos-git


Description
-------

See summary


Diffs (updated)
-----

  src/master/hierarchical_allocator_process.hpp 96b6ad569ea3758e4d078c6b2d60da4ea4fe8693 
  src/master/http.cpp 966eed6d8340038265ef799f1b6149502ccc606e 
  src/master/master.hpp 737bd8b5a1cd88a98a7f094795c50547079921ba 
  src/master/master.cpp a4e1b1f7327f01eb16f14c3fa08fc7a62048d36c 
  src/slave/cgroups_isolator.hpp 1a66dc630f0857db48b7cfb316fbbb15518fcec2 
  src/slave/cgroups_isolator.cpp ef7dd682e5462d0158d6ea6654246d77000e9778 
  src/slave/http.cpp c4f598faf6807214608cc89a6d9cf665133f95f3 
  src/slave/process_isolator.hpp bc52f33d8e83fe026be712c8b15e689eb23dd65c 
  src/slave/slave.hpp 2ddadb411f8b2f91a4a5038664f424d4eadfbb87 
  src/slave/slave.cpp 213df86084e51ab8407c6f2c2bd24ba718560faa 
  src/slave/status_update_manager.hpp 06ea4659cdd24cb1b82f389f404566ba14a663fb 
  src/slave/status_update_manager.cpp 03f5eafefd6ed748bfd4511d654c23c7b460db66 

Diff: https://reviews.apache.org/r/18249/diff/


Testing
-------

no functional change expected.

built. ran make check.


Thanks,

Dominic Hamon


Re: Review Request 18249: Removed 'using namespace process' from header files.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18249/#review34814
-----------------------------------------------------------

Ship it!



src/master/http.cpp
<https://reviews.apache.org/r/18249/#comment65170>

    Should these go up with the other process::http::* using clauses, or should those come down? Or maybe a note that these need to be here because of the presence of some other Response / Request types?


- Ben Mahler


On Feb. 19, 2014, 12:10 a.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18249/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2014, 12:10 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-1015
>     https://issues.apache.org/jira/browse/MESOS-1015
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary
> 
> 
> Diffs
> -----
> 
>   src/master/hierarchical_allocator_process.hpp 96b6ad569ea3758e4d078c6b2d60da4ea4fe8693 
>   src/master/http.cpp 966eed6d8340038265ef799f1b6149502ccc606e 
>   src/master/master.hpp 737bd8b5a1cd88a98a7f094795c50547079921ba 
>   src/master/master.cpp a4e1b1f7327f01eb16f14c3fa08fc7a62048d36c 
>   src/slave/cgroups_isolator.hpp 1a66dc630f0857db48b7cfb316fbbb15518fcec2 
>   src/slave/cgroups_isolator.cpp ef7dd682e5462d0158d6ea6654246d77000e9778 
>   src/slave/http.cpp c4f598faf6807214608cc89a6d9cf665133f95f3 
>   src/slave/process_isolator.hpp bc52f33d8e83fe026be712c8b15e689eb23dd65c 
>   src/slave/slave.hpp 2ddadb411f8b2f91a4a5038664f424d4eadfbb87 
>   src/slave/slave.cpp 213df86084e51ab8407c6f2c2bd24ba718560faa 
>   src/slave/status_update_manager.hpp 06ea4659cdd24cb1b82f389f404566ba14a663fb 
>   src/slave/status_update_manager.cpp 03f5eafefd6ed748bfd4511d654c23c7b460db66 
> 
> Diff: https://reviews.apache.org/r/18249/diff/
> 
> 
> Testing
> -------
> 
> no functional change expected.
> 
> built. ran make check.
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Re: Review Request 18249: Removed 'using namespace process' from header files.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18249/#review34816
-----------------------------------------------------------

Ship it!



src/slave/http.cpp
<https://reviews.apache.org/r/18249/#comment65174>

    Do these need to be inside the namespaces? If so, a brief comment might keep people from moving them outside and then paying the price. ;)


- Benjamin Hindman


On Feb. 19, 2014, 12:10 a.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18249/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2014, 12:10 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-1015
>     https://issues.apache.org/jira/browse/MESOS-1015
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary
> 
> 
> Diffs
> -----
> 
>   src/master/hierarchical_allocator_process.hpp 96b6ad569ea3758e4d078c6b2d60da4ea4fe8693 
>   src/master/http.cpp 966eed6d8340038265ef799f1b6149502ccc606e 
>   src/master/master.hpp 737bd8b5a1cd88a98a7f094795c50547079921ba 
>   src/master/master.cpp a4e1b1f7327f01eb16f14c3fa08fc7a62048d36c 
>   src/slave/cgroups_isolator.hpp 1a66dc630f0857db48b7cfb316fbbb15518fcec2 
>   src/slave/cgroups_isolator.cpp ef7dd682e5462d0158d6ea6654246d77000e9778 
>   src/slave/http.cpp c4f598faf6807214608cc89a6d9cf665133f95f3 
>   src/slave/process_isolator.hpp bc52f33d8e83fe026be712c8b15e689eb23dd65c 
>   src/slave/slave.hpp 2ddadb411f8b2f91a4a5038664f424d4eadfbb87 
>   src/slave/slave.cpp 213df86084e51ab8407c6f2c2bd24ba718560faa 
>   src/slave/status_update_manager.hpp 06ea4659cdd24cb1b82f389f404566ba14a663fb 
>   src/slave/status_update_manager.cpp 03f5eafefd6ed748bfd4511d654c23c7b460db66 
> 
> Diff: https://reviews.apache.org/r/18249/diff/
> 
> 
> Testing
> -------
> 
> no functional change expected.
> 
> built. ran make check.
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>