You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/06/01 14:31:19 UTC
[GitHub] [cordova-android] fserb opened a new pull request #983: Remove gradle.daemon from default forced settings
fserb opened a new pull request #983:
URL: https://github.com/apache/cordova-android/pull/983
### Platforms affected
All.
### Motivation and Context
https://github.com/apache/cordova-android/issues/982
### Description
This removes the forced setting of `gradle.daemon` to be true. Because gradle does daemon by default, this won't impact behavior. Except that now if users set gradle.daemon to false, it will respect that instead of overwriting.
In theory there's still a bad behavior in the code of not allowing defaults to be overwritten at all, but it's beyond the scope of this PR.
### Testing
`npm test` passes (and leaves a daemon behind).
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [x] I added automated test coverage as appropriate for this change
- [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [x] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-commenter commented on pull request #983: Remove gradle.daemon from default forced settings
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #983:
URL: https://github.com/apache/cordova-android/pull/983#issuecomment-636894979
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/983?src=pr&el=h1) Report
> Merging [#983](https://codecov.io/gh/apache/cordova-android/pull/983?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/a830145f36c8bba2ecdf7910f3699116d4c2f018&el=desc) will **decrease** coverage by `0.10%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/983?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #983 +/- ##
==========================================
- Coverage 68.11% 68.00% -0.11%
==========================================
Files 21 21
Lines 1866 1866
==========================================
- Hits 1271 1269 -2
- Misses 595 597 +2
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/983?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...lates/cordova/lib/config/GradlePropertiesParser.js](https://codecov.io/gh/apache/cordova-android/pull/983/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jb25maWcvR3JhZGxlUHJvcGVydGllc1BhcnNlci5qcw==) | `86.27% <ø> (ø)` | |
| [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/983/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `57.60% <0.00%> (-0.93%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/983?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/983?src=pr&el=footer). Last update [a830145...ce7bd70](https://codecov.io/gh/apache/cordova-android/pull/983?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-commenter edited a comment on pull request #983: Remove gradle.daemon from default forced settings
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #983:
URL: https://github.com/apache/cordova-android/pull/983#issuecomment-636894979
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/983?src=pr&el=h1) Report
> Merging [#983](https://codecov.io/gh/apache/cordova-android/pull/983?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/a830145f36c8bba2ecdf7910f3699116d4c2f018&el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/983?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #983 +/- ##
==========================================
- Coverage 68.11% 68.06% -0.06%
==========================================
Files 21 21
Lines 1866 1866
==========================================
- Hits 1271 1270 -1
- Misses 595 596 +1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/983?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...lates/cordova/lib/config/GradlePropertiesParser.js](https://codecov.io/gh/apache/cordova-android/pull/983/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jb25maWcvR3JhZGxlUHJvcGVydGllc1BhcnNlci5qcw==) | `86.27% <ø> (ø)` | |
| [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/983/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `58.06% <0.00%> (-0.47%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/983?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/983?src=pr&el=footer). Last update [a830145...ce7bd70](https://codecov.io/gh/apache/cordova-android/pull/983?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-commenter edited a comment on pull request #983: Remove gradle.daemon from default forced settings
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #983:
URL: https://github.com/apache/cordova-android/pull/983#issuecomment-636894979
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/983?src=pr&el=h1) Report
> Merging [#983](https://codecov.io/gh/apache/cordova-android/pull/983?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/a830145f36c8bba2ecdf7910f3699116d4c2f018&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/983?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #983 +/- ##
=======================================
Coverage 68.11% 68.11%
=======================================
Files 21 21
Lines 1866 1866
=======================================
Hits 1271 1271
Misses 595 595
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/983?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...lates/cordova/lib/config/GradlePropertiesParser.js](https://codecov.io/gh/apache/cordova-android/pull/983/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jb25maWcvR3JhZGxlUHJvcGVydGllc1BhcnNlci5qcw==) | `86.27% <ø> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/983?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/983?src=pr&el=footer). Last update [a830145...ce7bd70](https://codecov.io/gh/apache/cordova-android/pull/983?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] erisu closed pull request #983: Remove gradle.daemon from default forced settings
Posted by GitBox <gi...@apache.org>.
erisu closed pull request #983:
URL: https://github.com/apache/cordova-android/pull/983
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org