You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "jamesnetherton (via GitHub)" <gi...@apache.org> on 2023/02/10 13:32:04 UTC
[GitHub] [camel-quarkus] jamesnetherton opened a new issue, #4557: `QuarkusVertxWebsocketHost` should return the actual port for the HTTP server
jamesnetherton opened a new issue, #4557:
URL: https://github.com/apache/camel-quarkus/issues/4557
Currently [`QuarkusVertxWebsocketHost`](https://github.com/apache/camel-quarkus/blob/7dc82684910a20ea10159950390773ed6e3896c7/extensions/vertx-websocket/runtime/src/main/java/org/apache/camel/quarkus/component/vertx/websocket/VertxWebsocketRecorder.java#L50) does not return the actual port used by the underlying HTTP server.
This prohibits the `vertx-websocket` producer from being used against the local server like:
```java
.to("vertx-websocket:localhost:8080/foo");
```
There's an undocumented idiom that works instead like:
```java
.to("vertx-websocket:///foo");
```
But, it's a pain to maintain the logic to make it work properly. So I'd like to get rid of it and force usage of the standard `host:port/path` style.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ebullient commented on issue #4557: `QuarkusVertxWebsocketHost` should return the actual port for the HTTP server
Posted by "ebullient (via GitHub)" <gi...@apache.org>.
ebullient commented on issue #4557:
URL: https://github.com/apache/camel-quarkus/issues/4557#issuecomment-1426247901
> > it could be the http port or the test port
>
> Which is a UX issue. Because that split ends up leading to wackiness like this:
>
> https://github.com/apache/camel-quarkus/blob/23721fee0c62b6fe4503ed1250a2adaddf0b4ee1/integration-test-groups/foundation/timer/src/main/java/org/apache/camel/quarkus/component/timer/it/TimerProducers.java#L37-L41
That could be a usability improvement to Quarkus itself (to give you / return the effective port). Also.. that logic isn't quite correct. A JVM-mode integration test will also use the httpPort instead of the httpTestPort...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on issue #4557: `QuarkusVertxWebsocketHost` should return the actual port for the HTTP server
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on issue #4557:
URL: https://github.com/apache/camel-quarkus/issues/4557#issuecomment-1426029204
> That form is documented here
Yes. For the WS consumer (`from(...)`) where specifying the `host:port` makes little sense on Quarkus.
For the WS producer (`to(..)`) you could either be connecting to the local Quarkus HTTP server or some externally hosted WebSocket. Hence `host:port/path` makes sense in that scenario.
I'm not advocating folks hard code the host / port either. Camel can resolve Quarkus config properties like:
```
.to("vertx-websocket:localhost:{{quarkus.http.port}}");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ebullient commented on issue #4557: `QuarkusVertxWebsocketHost` should return the actual port for the HTTP server
Posted by "ebullient (via GitHub)" <gi...@apache.org>.
ebullient commented on issue #4557:
URL: https://github.com/apache/camel-quarkus/issues/4557#issuecomment-1426053966
y.. the trouble is (even in that case) it could be the http port or the test port, depending on where/when/how things are being invoked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ebullient commented on issue #4557: `QuarkusVertxWebsocketHost` should return the actual port for the HTTP server
Posted by "ebullient (via GitHub)" <gi...@apache.org>.
ebullient commented on issue #4557:
URL: https://github.com/apache/camel-quarkus/issues/4557#issuecomment-1426012388
`.to("vertx-websocket:localhost:8080/foo")` .. that doesn't work so well given profile-specific ways to change the host and/or port, though, does it (w/ late binding config injection scoped by quarkus profile?)
I personally would never use the hard-coded host:port form.. ever. The implied/disovered is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on issue #4557: `QuarkusVertxWebsocketHost` should return the actual port for the HTTP server
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on issue #4557:
URL: https://github.com/apache/camel-quarkus/issues/4557#issuecomment-1426078425
> it could be the http port or the test port
Which is a UX issue. Because that split ends up leading to wackiness like this:
https://github.com/apache/camel-quarkus/blob/23721fee0c62b6fe4503ed1250a2adaddf0b4ee1/integration-test-groups/foundation/timer/src/main/java/org/apache/camel/quarkus/component/timer/it/TimerProducers.java#L37-L41
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on issue #4557: `QuarkusVertxWebsocketHost` should return the actual port for the HTTP server
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on issue #4557:
URL: https://github.com/apache/camel-quarkus/issues/4557#issuecomment-1426106483
Given the feedback, let me rethink this change and experiment a bit more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga closed issue #4557: `QuarkusVertxWebsocketHost` should return the actual port for the HTTP server
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga closed issue #4557: `QuarkusVertxWebsocketHost` should return the actual port for the HTTP server
URL: https://github.com/apache/camel-quarkus/issues/4557
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org