You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by hl...@apache.org on 2010/05/05 01:09:23 UTC

svn commit: r941086 - in /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components: LinkSubmit.java Submit.java

Author: hlship
Date: Tue May  4 23:09:22 2010
New Revision: 941086

URL: http://svn.apache.org/viewvc?rev=941086&view=rev
Log:
TAP5-1127: Documentation for the Submit and LinkSubmit components should identify that you should cancel defer when inside a Loop

Modified:
    tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/LinkSubmit.java
    tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Submit.java

Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/LinkSubmit.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/LinkSubmit.java?rev=941086&r1=941085&r2=941086&view=diff
==============================================================================
--- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/LinkSubmit.java (original)
+++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/LinkSubmit.java Tue May  4 23:09:22 2010
@@ -60,7 +60,9 @@ public class LinkSubmit implements Clien
 
     /**
      * If true (the default), then any notification sent by the component will be deferred until the end of the form
-     * submission (this is usually desirable).
+     * submission (this is usually desirable).  In general, this can be left as the default except when the LinkSubmit
+     * component is rendering inside a {@link Loop}, in which case defer should be bound to false (otherwise, the
+     * event context will always be the final value of the Loop).
      */
     @Parameter
     private boolean defer = true;

Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Submit.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Submit.java?rev=941086&r1=941085&r2=941086&view=diff
==============================================================================
--- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Submit.java (original)
+++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Submit.java Tue May  4 23:09:22 2010
@@ -38,7 +38,9 @@ public class Submit implements ClientEle
 {
     /**
      * If true (the default), then any notification sent by the component will be deferred until the end of the form
-     * submission (this is usually desirable).
+     * submission (this is usually desirable). In general, this can be left as the default except when the Submit
+     * component is rendering inside a {@link Loop}, in which case defer should be bound to false (otherwise, the
+     * event context will always be the final value of the Loop).
      */
     @Parameter
     private boolean defer = true;