You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2021/01/12 19:21:47 UTC
Review Request 73135: Removed unused io watcher queue from libev.cpp.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73135/
-----------------------------------------------------------
Review request for mesos and Ilya Pronin.
Repository: mesos
Description
-------
The TODO removed in this change was implemented long ago, and hence
the io watchers queue is no longer used.
Diffs
-----
3rdparty/libprocess/src/posix/libev/libev.hpp d451931871db650894e4a6e5b0d19ba876f65391
3rdparty/libprocess/src/posix/libev/libev.cpp b38e7a0f882a8c24950bdc6fd74a4d25fc68549e
Diff: https://reviews.apache.org/r/73135/diff/1/
Testing
-------
make check
Thanks,
Benjamin Mahler
Re: Review Request 73135: Removed unused io watcher queue from
libev.cpp.
Posted by Ilya Pronin <ip...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73135/#review222446
-----------------------------------------------------------
Ship it!
Ship It!
- Ilya Pronin
On Jan. 12, 2021, 11:21 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73135/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2021, 11:21 a.m.)
>
>
> Review request for mesos and Ilya Pronin.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The TODO removed in this change was implemented long ago, and hence
> the io watchers queue is no longer used.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/posix/libev/libev.hpp d451931871db650894e4a6e5b0d19ba876f65391
> 3rdparty/libprocess/src/posix/libev/libev.cpp b38e7a0f882a8c24950bdc6fd74a4d25fc68549e
>
>
> Diff: https://reviews.apache.org/r/73135/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>