You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/05/27 11:01:25 UTC
[GitHub] [commons-lang] stevebosman-oc opened a new pull request, #901: Fix unstable coverage of CharSequenceUtils tests noticed during merge of PRs 898 and 899
stevebosman-oc opened a new pull request, #901:
URL: https://github.com/apache/commons-lang/pull/901
line 36 in CharSequenceUtils seems to usually return true, but because the majority of the tests rely on random string, occasionally (for instance in PR 898) it doesn't.
Contributed on behalf of the @opencastsoftware open source team
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] codecov-commenter commented on pull request #901: Fix unstable coverage of CharSequenceUtils tests noticed during merge of PRs 898 and 899
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #901:
URL: https://github.com/apache/commons-lang/pull/901#issuecomment-1139514733
# [Codecov](https://codecov.io/gh/apache/commons-lang/pull/901?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#901](https://codecov.io/gh/apache/commons-lang/pull/901?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (618400c) into [master](https://codecov.io/gh/apache/commons-lang/commit/a88dda4b749c73291feded0b7b5effa1556959d4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a88dda4) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #901 +/- ##
=========================================
Coverage 91.41% 91.41%
Complexity 7389 7389
=========================================
Files 188 188
Lines 15966 15966
Branches 2998 2998
=========================================
Hits 14595 14595
Misses 764 764
Partials 607 607
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/commons-lang/pull/901?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/commons-lang/pull/901?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a88dda4...618400c](https://codecov.io/gh/apache/commons-lang/pull/901?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #901: Fix unstable coverage of CharSequenceUtils tests noticed during merge of PRs 898 and 899
Posted by GitBox <gi...@apache.org>.
garydgregory commented on PR #901:
URL: https://github.com/apache/commons-lang/pull/901#issuecomment-1139543160
Hi @stevebosman-oc
Thank you for your PR.
This report says there is no difference in code coverage: https://app.codecov.io/gh/apache/commons-lang/commit/618400c7d870308b14a09f2555270eb3193f194c
How did you notice the difference?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] stevebosman-oc commented on pull request #901: Fix unstable coverage of CharSequenceUtils tests noticed during merge of PRs 898 and 899
Posted by GitBox <gi...@apache.org>.
stevebosman-oc commented on PR #901:
URL: https://github.com/apache/commons-lang/pull/901#issuecomment-1139548849
Yes, randomness can be a problem sometimes.
I noticed in #898 the coverage dropped unexpectedly and then for #899 it came back. I then repeated the run a few times in my IDE and analysed the differences in the strings used on the runs that had slightly better coverage compared to the ones that didn't. Since making this change I have done several runs and the coverage has not dropped back down again so I have convinced myself that it is fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory merged pull request #901: Fix unstable coverage of CharSequenceUtils tests noticed during merge of PRs 898 and 899
Posted by GitBox <gi...@apache.org>.
garydgregory merged PR #901:
URL: https://github.com/apache/commons-lang/pull/901
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #901: Fix unstable coverage of CharSequenceUtils tests noticed during merge of PRs 898 and 899
Posted by GitBox <gi...@apache.org>.
garydgregory commented on PR #901:
URL: https://github.com/apache/commons-lang/pull/901#issuecomment-1139545750
Ah... I noticed your comment on random strings. Yeah, random tests are not great :-(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org