[GitHub] [cordova-plugin-statusbar] breautek commented on a change in pull request #142: Update StatusBar.java

[GitBox <gi...@apache.org>]

breautek commented on a change in pull request #142: Update StatusBar.java
URL: https://github.com/apache/cordova-plugin-statusbar/pull/142#discussion_r331796954
 
 

 ##########
 File path: src/android/StatusBar.java
 ##########
 @@ -64,6 +64,9 @@ public void run() {
 
                 // Read 'StatusBarStyle' from config.xml, default is 'lightcontent'.
                 setStatusBarStyle(preferences.getString("StatusBarStyle", "lightcontent"));
+
+                // Read 'StatusBarOverlaysWebView' from config.xml, default is false.
+                setStatusBarTransparent(preferences.getBoolean("StatusBarOverlaysWebView", false));
 
 Review comment:
   I've raised an issue describing this at https://github.com/apache/cordova-plugin-statusbar/issues/159 because I think the statusbar plugin should be smarter in handling this. But for now, I agree, the workaround is to invoke `setStatusBarTransparent` before `setStatusBarBackgroundColor`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org