[GitHub] [lucene-solr] sigram commented on a change in pull request #825: SOLR-13677 All Metrics Gauges should be unregistered by the objects that registered them

[GitBox <gi...@apache.org>]

sigram commented on a change in pull request #825: SOLR-13677 All Metrics Gauges should be unregistered by the objects that registered them
URL: https://github.com/apache/lucene-solr/pull/825#discussion_r312814903
 
 

 ##########
 File path: solr/core/src/java/org/apache/solr/search/LFUCache.java
 ##########
 @@ -227,6 +227,7 @@ public void close() {
     statsList.get(0).add(cache.getStats());
     statsList.remove(cache.getStats());
     cache.destroy();
+
 
 Review comment:
   `metricsInfo.unregister()` ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org