You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by dtrodrigues <gi...@git.apache.org> on 2018/06/24 17:30:42 UTC

[GitHub] nifi-minifi-cpp pull request #364: MINIFICPP-538 - only print error on actua...

GitHub user dtrodrigues opened a pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/364

    MINIFICPP-538 - only print error on actual error during shutdown, upd…

    …ate semaphore name
    
    Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced
         in the commit message?
    
    - [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [ ] If applicable, have you updated the LICENSE file?
    - [ ] If applicable, have you updated the NOTICE file?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dtrodrigues/nifi-minifi-cpp MINIFICPP-538

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi-minifi-cpp/pull/364.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #364
    
----
commit 79a6b4083d433b9f96ac0fa9484f020a50c158af
Author: Dustin Rodrigues <du...@...>
Date:   2018-06-24T17:30:02Z

    MINIFICPP-538 - only print error on actual error during shutdown, update semaphore name

----


---

[GitHub] nifi-minifi-cpp pull request #364: MINIFICPP-538 - only print error on actua...

Posted by phrocker <gi...@git.apache.org>.
Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/364#discussion_r197815585
  
    --- Diff: main/MiNiFiMain.cpp ---
    @@ -71,7 +71,7 @@ int main(int argc, char **argv) {
       std::string nifi_configuration_class_name = "yamlconfiguration";
       std::string content_repo_class = "filesystemrepository";
     
    -  running = sem_open("MiNiFiMain", O_CREAT, 0644, 0);
    +  running = sem_open("/MiNiFiMain", O_CREAT, 0644, 0);
    --- End diff --
    
    Might have to have to use a relative path here. May actually want to use MINIFI_HOME here to avoid issues. 


---

[GitHub] nifi-minifi-cpp pull request #364: MINIFICPP-538 - only print error on actua...

Posted by phrocker <gi...@git.apache.org>.
Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/364#discussion_r197820271
  
    --- Diff: main/MiNiFiMain.cpp ---
    @@ -71,7 +71,7 @@ int main(int argc, char **argv) {
       std::string nifi_configuration_class_name = "yamlconfiguration";
       std::string content_repo_class = "filesystemrepository";
     
    -  running = sem_open("MiNiFiMain", O_CREAT, 0644, 0);
    +  running = sem_open("/MiNiFiMain", O_CREAT, 0644, 0);
    --- End diff --
    
    Err, what I meant was put this in a header relative to this one. I recall having several at one point during dev, MiNiFiMain, /MiNiFiMain, Controller, and /Controller. The non-path variants were names to be printed into log statements. Further, may be useful to print the error to the log instead of stderr with strerror later down. 


---

[GitHub] nifi-minifi-cpp pull request #364: MINIFICPP-538 - only print error on actua...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/nifi-minifi-cpp/pull/364


---

[GitHub] nifi-minifi-cpp pull request #364: MINIFICPP-538 - only print error on actua...

Posted by phrocker <gi...@git.apache.org>.
Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/364#discussion_r199121963
  
    --- Diff: main/MiNiFiMain.cpp ---
    @@ -71,7 +71,7 @@ int main(int argc, char **argv) {
       std::string nifi_configuration_class_name = "yamlconfiguration";
       std::string content_repo_class = "filesystemrepository";
     
    -  running = sem_open("MiNiFiMain", O_CREAT, 0644, 0);
    +  running = sem_open("/MiNiFiMain", O_CREAT, 0644, 0);
    --- End diff --
    
    Merging to get this closed, but created https://issues.apache.org/jira/browse/MINIFICPP-548 for the labels and logging


---