You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/11/07 23:42:31 UTC

[GitHub] [pulsar-helm-chart] frankjkelly opened a new pull request #172: Another fix for #158. Bookie Service also needs the prefix on the port name

frankjkelly opened a new pull request #172:
URL: https://github.com/apache/pulsar-helm-chart/pull/172


   Fixes #158 (This is the second PR - see also https://github.com/apache/pulsar-helm-chart/pull/162)
   
   ### Motivation
   
   * All non-standard port-names need a proper protocol prefix to support Istio
    https://istio.io/latest/docs/ops/configuration/traffic-management/protocol-selection/#explicit-protocol-selection
    
   ### Modifications
   
   Add the prefix value before `bookie`
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   NOTE: Unclear how testing in several of my environments missed this even though Istio mTLS was turned on etc.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-helm-chart] sijie merged pull request #172: Another fix for #158. Bookie Service also needs the prefix on the port name

Posted by GitBox <gi...@apache.org>.

sijie merged pull request #172:
URL: https://github.com/apache/pulsar-helm-chart/pull/172


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org