You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/17 14:34:40 UTC
[GitHub] [airflow] ashishpatel0720 opened a new issue #15416: Breeze should load local tmux configuration in 'breeze start-airflow'
ashishpatel0720 opened a new issue #15416:
URL: https://github.com/apache/airflow/issues/15416
<!--
Welcome to Apache Airflow! For a smooth issue process, try to answer the following questions.
Don't worry if they're not all applicable; just try to include what you can :-)
If you need to include code snippets or logs, please put them in fenced code
blocks. If they're super-long, please use the details tag like
<details><summary>super-long log</summary> lots of stuff </details>
Please delete these comment blocks before submitting the issue.
-->
**Description**
Currently, when we run
`bash
breeze start-airflow
`
**breeze** doesn't load local tmux configuration file**.tmux.conf** and we get default tmux configuration inside the containers.
**Use case / motivation**
<!-- What do you want to happen?
Breeze must load local **tmux configuration** in to the containers and developers should be able to use their own configurations.
-->
**Are you willing to submit a PR?**
YES
<!--- We accept contributions! -->
**Related Issues**
None
<!-- Is there currently another issue associated with this? -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr edited a comment on issue #15416: breeze should load local tmux configuration in 'breeze start-airflow'
Posted by GitBox <gi...@apache.org>.
uranusjr edited a comment on issue #15416:
URL: https://github.com/apache/airflow/issues/15416#issuecomment-822860661
I wondered about this a while ago (mostly because I don’t want to repeatedly `set mouse on`). The problem is any slightly sophisticated local tmux setup would contain a lot of dependencies and it’s not realistic to pull them all into the container. So maybe a better approach would be have a directory in the repository; if the user puts a (git-ignored) `.tmux.conf` file in it, the file is mounted to the container’s `~/.tmux.conf`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on issue #15416: breeze should load local tmux configuration in 'breeze start-airflow'
Posted by GitBox <gi...@apache.org>.
uranusjr commented on issue #15416:
URL: https://github.com/apache/airflow/issues/15416#issuecomment-822860661
I wondered about this a while ago (mostly because I don’t want to repeatedly `set mouse on`). The problem is any slightly sophisticated local tmux setup would contain a lot of dependencies and it’s not realistic to pull them all into the container. So maybe a better approach would be have a directory *in the repository*; if the user puts a (git-ignored) `.tmux.conf` file in it, the file is mounted to the container’s `~/.tmux.conf`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on issue #15416: breeze should load local tmux configuration in 'breeze start-airflow'
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #15416:
URL: https://github.com/apache/airflow/issues/15416#issuecomment-822856333
SGTM. Can you submit a PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #15416: breeze should load local tmux configuration in 'breeze start-airflow'
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #15416:
URL: https://github.com/apache/airflow/issues/15416#issuecomment-823063125
We already have similar mechanism for reading user-supplied env variables placed in `files/airflow-breeze-config` folder.
https://github.com/apache/airflow/blob/130f9e32f49e10511863d05c03f3532269ae27db/scripts/in_container/configure_environment.sh#L36
It could be done in a very similar way .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashishpatel0720 commented on issue #15416: breeze should load local tmux configuration in 'breeze start-airflow'
Posted by GitBox <gi...@apache.org>.
ashishpatel0720 commented on issue #15416:
URL: https://github.com/apache/airflow/issues/15416#issuecomment-823049770
> SGTM. Can you submit a PR?
Yes I will.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed issue #15416: breeze should load local tmux configuration in 'breeze start-airflow'
Posted by GitBox <gi...@apache.org>.
potiuk closed issue #15416:
URL: https://github.com/apache/airflow/issues/15416
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashishpatel0720 commented on issue #15416: breeze should load local tmux configuration in 'breeze start-airflow'
Posted by GitBox <gi...@apache.org>.
ashishpatel0720 commented on issue #15416:
URL: https://github.com/apache/airflow/issues/15416#issuecomment-823127083
> We already have similar mechanism for reading user-supplied env variables placed in `files/airflow-breeze-config` folder.
> https://github.com/apache/airflow/blob/130f9e32f49e10511863d05c03f3532269ae27db/scripts/in_container/configure_environment.sh#L36
>
> It could be done in a very similar way .
thanks @potiuk, let me check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pateash edited a comment on issue #15416: breeze should load local tmux configuration in 'breeze start-airflow'
Posted by GitBox <gi...@apache.org>.
pateash edited a comment on issue #15416:
URL: https://github.com/apache/airflow/issues/15416#issuecomment-823297407
PR #15454
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashishpatel0720 commented on issue #15416: breeze should load local tmux configuration in 'breeze start-airflow'
Posted by GitBox <gi...@apache.org>.
ashishpatel0720 commented on issue #15416:
URL: https://github.com/apache/airflow/issues/15416#issuecomment-823297407
PR #15454
I guess, I have to update docs as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org