You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/02/25 21:26:06 UTC

[GitHub] [calcite] vineetgarg02 commented on a change in pull request #1828: [CALCITE-3734] MySQL JDBC rewrite is producing queries with CHAR with range beyond 255 (Vineet Garg)

vineetgarg02 commented on a change in pull request #1828: [CALCITE-3734] MySQL JDBC rewrite is producing queries with CHAR with range beyond 255 (Vineet Garg)
URL: https://github.com/apache/calcite/pull/1828#discussion_r384135463
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/sql/dialect/MysqlSqlDialect.java
 ##########
 @@ -67,7 +84,7 @@
 
   /** Creates a MysqlSqlDialect. */
   public MysqlSqlDialect(Context context) {
-    super(context);
+    super(context.withDataTypeSystem(MYSQL_TYPE_SYSTEM));
 
 Review comment:
   This is needed because `SqlDialectFactoryImpl.create` creates dialect with its own context (without using DEFAULT context).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services