You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tez.apache.org by "TezQA (Jira)" <ji...@apache.org> on 2020/04/25 21:38:00 UTC
[jira] [Commented] (TEZ-4154) tez-protobuf: a single module for
handling protobuf dependency
[ https://issues.apache.org/jira/browse/TEZ-4154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092387#comment-17092387 ]
TezQA commented on TEZ-4154:
----------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 10m 25s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m 0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 46s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m 38s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m 37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 6m 6s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 4m 44s{color} | {color:blue} Used deprecated FindBugs config; considering switching to SpotBugs. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m 39s{color} | {color:red} root in master has 2 extant findbugs warnings. {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 16s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m 1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 6m 1s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 20s{color} | {color:orange} tez-protobuf: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 46s{color} | {color:orange} root: The patch generated 3 new + 47 unchanged - 0 fixed = 50 total (was 47) {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 23s{color} | {color:orange} tez-plugins/tez-aux-services: The patch generated 1 new + 47 unchanged - 0 fixed = 48 total (was 47) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 17s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 6m 21s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 5m 10s{color} | {color:red} root generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 22s{color} | {color:green} tez-protobuf in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 14m 15s{color} | {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 25s{color} | {color:green} hadoop-shim-2.8 in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 58s{color} | {color:green} tez-api in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 39s{color} | {color:green} tez-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 4m 32s{color} | {color:green} tez-dag in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 59s{color} | {color:green} tez-ext-service-tests in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 19s{color} | {color:green} tez-mapreduce in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 43s{color} | {color:green} tez-aux-services in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 32s{color} | {color:green} tez-protobuf-history-plugin in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 53s{color} | {color:green} tez-runtime-internals in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 4m 55s{color} | {color:green} tez-runtime-library in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 4m 22s{color} | {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black}129m 3s{color} | {color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:root |
| | The class name org.apache.tez.protobuf.GeneratedMessage shadows the simple name of the superclass com.google.protobuf.GeneratedMessage At GeneratedMessage.java:the simple name of the superclass com.google.protobuf.GeneratedMessage At GeneratedMessage.java:[lines 28-32] |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/PreCommit-TEZ-Build/366/artifact/out/Dockerfile |
| JIRA Issue | TEZ-4154 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/13001162/TEZ-4154.03.patch |
| Optional Tests | dupname asflicense javac javadoc unit xml compile spotbugs findbugs checkstyle |
| uname | Linux 08f2411df827 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / 3f8e753 |
| Default Java | 1.8.0_252 |
| findbugs | https://builds.apache.org/job/PreCommit-TEZ-Build/366/artifact/out/branch-findbugs-root-warnings.html |
| checkstyle | https://builds.apache.org/job/PreCommit-TEZ-Build/366/artifact/out/diff-checkstyle-tez-protobuf.txt |
| checkstyle | https://builds.apache.org/job/PreCommit-TEZ-Build/366/artifact/out/diff-checkstyle-root.txt |
| checkstyle | https://builds.apache.org/job/PreCommit-TEZ-Build/366/artifact/out/diff-checkstyle-tez-plugins_tez-aux-services.txt |
| findbugs | https://builds.apache.org/job/PreCommit-TEZ-Build/366/artifact/out/new-findbugs-root.html |
| unit | https://builds.apache.org/job/PreCommit-TEZ-Build/366/artifact/out/patch-unit-root.txt |
| Test Results | https://builds.apache.org/job/PreCommit-TEZ-Build/366/testReport/ |
| Max. process+thread count | 1635 (vs. ulimit of 5500) |
| modules | C: tez-protobuf . hadoop-shim-impls/hadoop-shim-2.8 tez-api tez-common tez-dag tez-ext-service-tests tez-mapreduce tez-plugins/tez-aux-services tez-plugins/tez-protobuf-history-plugin tez-runtime-internals tez-runtime-library U: . |
| Console output | https://builds.apache.org/job/PreCommit-TEZ-Build/366/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
> tez-protobuf: a single module for handling protobuf dependency
> --------------------------------------------------------------
>
> Key: TEZ-4154
> URL: https://issues.apache.org/jira/browse/TEZ-4154
> Project: Apache Tez
> Issue Type: Sub-task
> Reporter: László Bodor
> Assignee: László Bodor
> Priority: Major
> Attachments: TEZ-4154.01.patch, TEZ-4154.02.patch, TEZ-4154.03.patch
>
>
> Similarly to what I've seen in TEZ-2164, I would like to create a module that is a single point of control of how tez handles protobuf dependency. In the near future, when tez will upgrade to hadoop 3.3, there will be a couple of things which should be taken care of (see TEZ-4152), e.g. upgrade to protobuf 3.x and handle the possible mess that can come from the fact that hadoop has relocated its protobuf.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)