[jira] [Commented] (CB-10958) scripts/after_install.js overwrites content @src attribute

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-10958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15210725#comment-15210725 ] 

ASF GitHub Bot commented on CB-10958:
-------------------------------------

GitHub user ankon opened a pull request:

    https://github.com/apache/cordova-plugins/pull/24

    CB-10958: Retain the `src` attribute of the `content` element when it…

    … already points to localhost
    
    ----
    Note that this does also add a package.json file for the urijs dependency.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ankon/cordova-plugins upstream/CB-10958

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugins/pull/24.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #24
    
----
commit b43189e2667fb0cc3fbe643e32045830e5de5afa
Author: Andreas Kohn <an...@gmail.com>
Date:   2016-03-24T14:33:34Z

    CB-10958: Retain the `src` attribute of the `content` element when it already points to localhost

----


> scripts/after_install.js overwrites content @src attribute
> ----------------------------------------------------------
>
>                 Key: CB-10958
>                 URL: https://issues.apache.org/jira/browse/CB-10958
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: iOS
>            Reporter: Andreas Kohn
>
> The scripts/after_install.js script of the cordova-labs-local-webserver overwrites the 'src' attribute of the 'content' element when it is executed, always setting the port to '0' (randomised).
> This might be fine if one is working with the environment on a single checkout on a single machine, where one merely has to modify the file afterwards; it might also be fine when one opts to commit the platforms/ and plugins/ directories to source control.
> This doesn't seem a proper behaviour or assumption though: For example, in our environment we use the https://github.com/SamVerschueren/gulp-cordova plugins to produce a reproducible state as part of the integration build. A workaround would be to post-process the config.xml and restore the port we need, but it is fairly easy to fix in the cordoba-labs-local-webserver plugin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org