You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/08/09 03:48:56 UTC

[GitHub] feng-tao commented on a change in pull request #3648: [AIRFLOW-2786] Fix editing Variable with empty key crashing

feng-tao commented on a change in pull request #3648: [AIRFLOW-2786] Fix editing Variable with empty key crashing
URL: https://github.com/apache/incubator-airflow/pull/3648#discussion_r208799225
 
 

 ##########
 File path: tests/www_rbac/test_views.py
 ##########
 @@ -172,6 +172,26 @@ def test_xss_prevention(self):
         self.assertNotIn("<img src='' onerror='alert(1);'>",
                          resp.data.decode("utf-8"))
 
+    def test_import_variables(self):
+        import mock
 
 Review comment:
   nit: put the import mock among others lib import.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services