You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "not-my-profile (via GitHub)" <gi...@apache.org> on 2023/08/01 20:15:04 UTC
[GitHub] [arrow-datafusion] not-my-profile opened a new pull request, #7172: fix: skip compression tests on --no-default-features
not-my-profile opened a new pull request, #7172:
URL: https://github.com/apache/arrow-datafusion/pull/7172
Previously `cargo test -p datafusion --no-default-features --lib` failed with 77 tests panicking with the message:
> Compression is not supported in this build
This commit fixes this test failure under --no-default-features by excluding the tests via `#[cfg(feature = "compression")]`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jackwener commented on pull request #7172: fix: skip compression tests on --no-default-features
Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on PR #7172:
URL: https://github.com/apache/arrow-datafusion/pull/7172#issuecomment-1661451534
Thanks @not-my-profile
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jackwener merged pull request #7172: fix: skip compression tests on --no-default-features
Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener merged PR #7172:
URL: https://github.com/apache/arrow-datafusion/pull/7172
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] not-my-profile commented on pull request #7172: fix: skip compression tests on --no-default-features
Posted by "not-my-profile (via GitHub)" <gi...@apache.org>.
not-my-profile commented on PR #7172:
URL: https://github.com/apache/arrow-datafusion/pull/7172#issuecomment-1661024869
Perhaps the CI should run the tests with `--no-default-features` as well to spot such errors?
https://github.com/apache/arrow-datafusion/blob/7af25decf0505fe9f835b7440fc498cad90dde35/.github/workflows/rust.yml#L98-L99
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org