You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/11/01 04:01:36 UTC

[GitHub] [nifi] exceptionfactory opened a new pull request, #6608: NIFI-10737 Correct ListenBeats buffer handling

exceptionfactory opened a new pull request, #6608:
URL: https://github.com/apache/nifi/pull/6608

   # Summary
   
   [NIFI-10737](https://issues.apache.org/jira/browse/NIFI-10737) Corrects the behavior of the `ListenBeats` Processor when reading a socket buffer where the buffer size is greater than 2048 bytes.
   
   The Netty framework can invoke handlers with a `ByteBuf` containing any number of bytes, so the handler implementations must be capable of checking for available bytes and resuming operation on subsequent invocations.
   
   Changes include adding a new unit test for `ListenBeats`, removing unnecessary dependencies from `nifi-beats-processors`, and implementing a new `BatchDecoder` class for reading Beats Protocol frames. The protocol implementation follows the general approach of the [logstash-forwarder](https://github.com/elastic/logstash-forwarder) project for reading Beats Version 2 frames.
   
   The channel handler process is also more efficient as it sends a Message Acknowledgement  packet for the last Sequence Number from the batch of messages, as opposed to sending one for every message received.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [X] Build completed using `mvn clean install -P contrib-check`
     - [X] JDK 8
     - [ ] JDK 11
     - [ ] JDK 17
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] thenatog commented on pull request #6608: NIFI-10737 Correct ListenBeats buffer handling

Posted by GitBox <gi...@apache.org>.
thenatog commented on PR #6608:
URL: https://github.com/apache/nifi/pull/6608#issuecomment-1303869363

   Will review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] thenatog commented on pull request #6608: NIFI-10737 Correct ListenBeats buffer handling

Posted by GitBox <gi...@apache.org>.
thenatog commented on PR #6608:
URL: https://github.com/apache/nifi/pull/6608#issuecomment-1306288516

   +1 looks good to me, tested this out and found that ListenBeats is working as expected. The refactor code changes look good. Will merge.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] thenatog closed pull request #6608: NIFI-10737 Correct ListenBeats buffer handling

Posted by GitBox <gi...@apache.org>.
thenatog closed pull request #6608: NIFI-10737 Correct ListenBeats buffer handling
URL: https://github.com/apache/nifi/pull/6608


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org