You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2018/12/19 17:52:07 UTC
Review Request 69597: Remove outstanding operations when removing
agents.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69597/
-----------------------------------------------------------
Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
Repository: mesos
Description
-------
Usually, offer operations are removed when the framework acknowledges
a terminal operation status update.
However, currently only operations on registered agents can be
acknowledged.
This commit explicitly deletes all outstanding offers from an agent
when it is about to be removed.
Diffs
-----
src/master/master.cpp b4b02d8b4d7d6d1aabda1f97b9bf824419f76a9e
Diff: https://reviews.apache.org/r/69597/diff/1/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 69597: Remove outstanding operations when removing
agents.
Posted by Benno Evers <be...@mesosphere.com>.
> On Dec. 20, 2018, 1:56 p.m., Benno Evers wrote:
> > src/master/master.cpp
> > Lines 8885 (patched)
> > <https://reviews.apache.org/r/69597/diff/2/?file=2115289#file2115289line8885>
> >
> > After some discussion with @bbannier, I moved the removal into `markGone()` since we were not sure that the master would be able to re-learn about the operations on the agent if it will re-appear again later.
> >
> > This also raises a question about master failovers: Do we lose all information about operations in this case, or is there some reconciliation mechanism for operations between master and agents?
After further discussion with Greg and Gaston, we decided to move the removal back to its original place (for the reasoning, see the updated comment in the code)
- Benno
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69597/#review211464
-----------------------------------------------------------
On Dec. 27, 2018, 4:51 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69597/
> -----------------------------------------------------------
>
> (Updated Dec. 27, 2018, 4:51 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gastón Kleiman, Greg Mann, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Usually, offer operations are removed when the framework acknowledges
> a terminal operation status update.
>
> However, currently only operations on registered agents can be
> acknowledged.
>
> This commit explicitly deletes all outstanding operations from an agent
> when it is removed.
>
>
> Diffs
> -----
>
> src/master/master.cpp b4faf2b077a0288ba36195b7a21402932489d316
>
>
> Diff: https://reviews.apache.org/r/69597/diff/4/
>
>
> Testing
> -------
>
> Internal CI results:
> ```
> Test Result
> 0 failures
> 38,673 tests
>
> Configuration Name Duration All Failed Skipped
> FLAG=Plain,label=mesos-ec2-ubuntu-16.04 18 min 3202 0 0
> FLAG=SSL,label=mac 9 min 27 sec 2698 0 0
> FLAG=CMake,label=mesos-ec2-centos-7 21 min 3146 0 0
> FLAG=CMake,label=mesos-ec2-ubuntu-16.04 18 min 3155 0 0
> FLAG=SSL,label=mesos-ec2-debian-8 21 min 3261 0 0
> FLAG=SSL,label=mesos-ec2-centos-7 20 min 3256 0 0
> FLAG=Plain,label=mesos-ec2-centos-7 20 min 3193 0 0
> FLAG=SSL,label=mesos-ec2-ubuntu-16.04 18 min 3265 0 0
> FLAG=SSL,label=mesos-ec2-ubuntu-14.04 19 min 3258 0 0
> FLAG=Clang,label=mesos-ec2-ubuntu-16.04 18 min 3202 0 0
> FLAG=SSL,label=mesos-ec2-debian-9 18 min 3263 0 0
> FLAG=SSL,label=mesos-ec2-centos-6 15 min 3168 0 0
> FLAG=BUILD_ISOLATORS,label=mesos-ec2-ubuntu-16.04 5.6 sec 606 0 0
> ```
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 69597: Remove outstanding operations when marking
agents as gone.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69597/#review211464
-----------------------------------------------------------
src/master/master.cpp
Lines 8885 (patched)
<https://reviews.apache.org/r/69597/#comment296622>
After some discussion with @bbannier, I moved the removal into `markGone()` since we were not sure that the master would be able to re-learn about the operations on the agent if it will re-appear again later.
This also raises a question about master failovers: Do we lose all information about operations in this case, or is there some reconciliation mechanism for operations between master and agents?
- Benno Evers
On Dec. 20, 2018, 1:46 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69597/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2018, 1:46 p.m.)
>
>
> Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Usually, offer operations are removed when the framework acknowledges
> a terminal operation status update.
>
> However, currently only operations on registered agents can be
> acknowledged.
>
> This commit explicitly deletes all outstanding offers from an agent
> when it is being marked gone.
>
>
> Diffs
> -----
>
> src/master/master.cpp b4b02d8b4d7d6d1aabda1f97b9bf824419f76a9e
>
>
> Diff: https://reviews.apache.org/r/69597/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 69597: Remove outstanding operations when removing
agents.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69597/
-----------------------------------------------------------
(Updated Dec. 27, 2018, 4:50 p.m.)
Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
Changes
-------
Revert to first revision of this patch.
Summary (updated)
-----------------
Remove outstanding operations when removing agents.
Repository: mesos
Description (updated)
-------
Usually, offer operations are removed when the framework acknowledges
a terminal operation status update.
However, currently only operations on registered agents can be
acknowledged.
This commit explicitly deletes all outstanding operations from an agent
when it is removed.
Diffs (updated)
-----
src/master/master.cpp b4faf2b077a0288ba36195b7a21402932489d316
Diff: https://reviews.apache.org/r/69597/diff/4/
Changes: https://reviews.apache.org/r/69597/diff/3-4/
Testing
-------
Internal CI results:
```
Test Result
0 failures
38,673 tests
Configuration Name Duration All Failed Skipped
FLAG=Plain,label=mesos-ec2-ubuntu-16.04 18 min 3202 0 0
FLAG=SSL,label=mac 9 min 27 sec 2698 0 0
FLAG=CMake,label=mesos-ec2-centos-7 21 min 3146 0 0
FLAG=CMake,label=mesos-ec2-ubuntu-16.04 18 min 3155 0 0
FLAG=SSL,label=mesos-ec2-debian-8 21 min 3261 0 0
FLAG=SSL,label=mesos-ec2-centos-7 20 min 3256 0 0
FLAG=Plain,label=mesos-ec2-centos-7 20 min 3193 0 0
FLAG=SSL,label=mesos-ec2-ubuntu-16.04 18 min 3265 0 0
FLAG=SSL,label=mesos-ec2-ubuntu-14.04 19 min 3258 0 0
FLAG=Clang,label=mesos-ec2-ubuntu-16.04 18 min 3202 0 0
FLAG=SSL,label=mesos-ec2-debian-9 18 min 3263 0 0
FLAG=SSL,label=mesos-ec2-centos-6 15 min 3168 0 0
FLAG=BUILD_ISOLATORS,label=mesos-ec2-ubuntu-16.04 5.6 sec 606 0 0
```
Thanks,
Benno Evers
Re: Review Request 69597: Remove outstanding operations when marking
agents as gone.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69597/
-----------------------------------------------------------
(Updated Dec. 21, 2018, 1:42 p.m.)
Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
Changes
-------
Add fixup and CI results.
Repository: mesos
Description
-------
Usually, offer operations are removed when the framework acknowledges
a terminal operation status update.
However, currently only operations on registered agents can be
acknowledged.
This commit explicitly deletes all outstanding offers from an agent
when it is being marked gone.
Diffs (updated)
-----
src/master/master.cpp b4faf2b077a0288ba36195b7a21402932489d316
Diff: https://reviews.apache.org/r/69597/diff/3/
Changes: https://reviews.apache.org/r/69597/diff/2-3/
Testing (updated)
-------
Internal CI results:
```
Test Result
0 failures
38,673 tests
Configuration Name Duration All Failed Skipped
FLAG=Plain,label=mesos-ec2-ubuntu-16.04 18 min 3202 0 0
FLAG=SSL,label=mac 9 min 27 sec 2698 0 0
FLAG=CMake,label=mesos-ec2-centos-7 21 min 3146 0 0
FLAG=CMake,label=mesos-ec2-ubuntu-16.04 18 min 3155 0 0
FLAG=SSL,label=mesos-ec2-debian-8 21 min 3261 0 0
FLAG=SSL,label=mesos-ec2-centos-7 20 min 3256 0 0
FLAG=Plain,label=mesos-ec2-centos-7 20 min 3193 0 0
FLAG=SSL,label=mesos-ec2-ubuntu-16.04 18 min 3265 0 0
FLAG=SSL,label=mesos-ec2-ubuntu-14.04 19 min 3258 0 0
FLAG=Clang,label=mesos-ec2-ubuntu-16.04 18 min 3202 0 0
FLAG=SSL,label=mesos-ec2-debian-9 18 min 3263 0 0
FLAG=SSL,label=mesos-ec2-centos-6 15 min 3168 0 0
FLAG=BUILD_ISOLATORS,label=mesos-ec2-ubuntu-16.04 5.6 sec 606 0 0
```
Thanks,
Benno Evers
Re: Review Request 69597: Remove outstanding operations when marking
agents as gone.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69597/
-----------------------------------------------------------
(Updated Dec. 20, 2018, 1:46 p.m.)
Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
Summary (updated)
-----------------
Remove outstanding operations when marking agents as gone.
Repository: mesos
Description (updated)
-------
Usually, offer operations are removed when the framework acknowledges
a terminal operation status update.
However, currently only operations on registered agents can be
acknowledged.
This commit explicitly deletes all outstanding offers from an agent
when it is being marked gone.
Diffs (updated)
-----
src/master/master.cpp b4b02d8b4d7d6d1aabda1f97b9bf824419f76a9e
Diff: https://reviews.apache.org/r/69597/diff/2/
Changes: https://reviews.apache.org/r/69597/diff/1-2/
Testing
-------
Thanks,
Benno Evers