You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by venkat sairam <ve...@gmail.com> on 2017/03/07 11:40:33 UTC
Review Request 57370: Issue with toggling of Execute/Stop button in
query page while successful and failure execution of query
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57370/
-----------------------------------------------------------
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
Bugs: AMBARI-20340
https://issues.apache.org/jira/browse/AMBARI-20340
Repository: ambari
Description
-------
We have passed the scope of controller to the function to execute it in the respecitve scope as closure.
Diffs
-----
contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js e1ab620
contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 1b18955
Diff: https://reviews.apache.org/r/57370/diff/1/
Testing
-------
Manual testing done
Thanks,
venkat sairam
Re: Review Request 57370: Issue with toggling of Execute/Stop button
in query page while successful and failure execution of query
Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57370/#review168119
-----------------------------------------------------------
Ship it!
Ship It!
- Pallav Kulshreshtha
On March 7, 2017, 11:40 a.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57370/
> -----------------------------------------------------------
>
> (Updated March 7, 2017, 11:40 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
>
>
> Bugs: AMBARI-20340
> https://issues.apache.org/jira/browse/AMBARI-20340
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We have passed the scope of controller to the function to execute it in the respecitve scope as closure.
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js e1ab620
> contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 1b18955
>
>
> Diff: https://reviews.apache.org/r/57370/diff/1/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> Thanks,
>
> venkat sairam
>
>
Re: Review Request 57370: Issue with toggling of Execute/Stop button
in query page while successful and failure execution of query
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57370/#review168269
-----------------------------------------------------------
Ship it!
Ship It!
- Gaurav Nagar
On March 7, 2017, 11:40 a.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57370/
> -----------------------------------------------------------
>
> (Updated March 7, 2017, 11:40 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
>
>
> Bugs: AMBARI-20340
> https://issues.apache.org/jira/browse/AMBARI-20340
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We have passed the scope of controller to the function to execute it in the respecitve scope as closure.
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js e1ab620
> contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 1b18955
>
>
> Diff: https://reviews.apache.org/r/57370/diff/1/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> Thanks,
>
> venkat sairam
>
>
Re: Review Request 57370: Issue with toggling of Execute/Stop button
in query page while successful and failure execution of query
Posted by Nitiraj Rathore <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57370/#review168251
-----------------------------------------------------------
Ship it!
Ship It!
- Nitiraj Rathore
On March 7, 2017, 11:40 a.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57370/
> -----------------------------------------------------------
>
> (Updated March 7, 2017, 11:40 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
>
>
> Bugs: AMBARI-20340
> https://issues.apache.org/jira/browse/AMBARI-20340
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We have passed the scope of controller to the function to execute it in the respecitve scope as closure.
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js e1ab620
> contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 1b18955
>
>
> Diff: https://reviews.apache.org/r/57370/diff/1/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> Thanks,
>
> venkat sairam
>
>