You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/28 07:54:57 UTC
[GitHub] [spark] toujours33 opened a new pull request #34419: [SPARK-37147][TESTS] Fix WorkerSuite failure on MacOS 10.15+
toujours33 opened a new pull request #34419:
URL: https://github.com/apache/spark/pull/34419
### What changes were proposed in this pull request?
Change Worker's workDir from ```/tmp``` to ```Utils.createTempDir``` in case WorkerSuite
### Why are the changes needed?
WorkerSuite fails on MacOS after pr [SPARK-35907](https://github.com/apache/spark/pull/33101).
WorkerSuite tries to create ```/tmp``` dir by ```FIles.createDirectories```, but /tmp is a softlink to /private/tmp on MacOs (both intel and m1), according to suite in [UtilsSuite](https://github.com/apache/spark/blob/master/core/src/test/scala/org/apache/spark/util/UtilsSuite.scala#L525), create directory on existed softlink will cause fail.
It's better to use temp directory instead of /tmp for work dir
### Does this PR introduce _any_ user-facing change?
no
### How was this patch tested?
pass GA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] toujours33 closed pull request #34419: [SPARK-37147][TESTS] Fix WorkerSuite failure on MacOS
Posted by GitBox <gi...@apache.org>.
toujours33 closed pull request #34419:
URL: https://github.com/apache/spark/pull/34419
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org