[GitHub] [flink] zentol edited a comment on issue #10285: [FLINK-14896] [flink-kinesis-connector] Set jackson and guava dependency to flink-shaded

[GitBox <gi...@apache.org>]

zentol edited a comment on issue #10285: [FLINK-14896] [flink-kinesis-connector] Set jackson and guava dependency to flink-shaded
URL: https://github.com/apache/flink/pull/10285#issuecomment-557709573
 
 
   Personally I'd say that we shouldn't change anything; relocated dependencies to me always imply that they are for internal usage. The very purpose of the relocation is after all to not interfere with other dependencies.
   Given that this issue only occurred when the relocated dependency is used in ways we didn't intend, I'd instead say the user should explicitly depend on the aws library, or possibly even just include it in the client classpath since it wouldn't be used within the actual job.
   
   We frequently exclude transitive dependencies because _we_ don't need hem; if we start considering what some user might use it for we'd unnecessarily bloat the classpath and jars imo.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services