[jira] [Updated] (BEAM-6577) The shim generator doesn't examine func return types when generating necessary imports

["Kenneth Knowles (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-6577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kenneth Knowles updated BEAM-6577:
----------------------------------
    Resolution: Fixed
        Status: Resolved  (was: Resolved)

Hello! Due to a bug in our Jira configuration, this issue had status:Resolved but resolution:Unresolved.

I am bulk editing these issues to have resolution:Fixed

If a different resolution is appropriate, please change it. To do this, click the "Resolve" button (you can do this even for closed issues) and set the Resolution field to the right value.

> The shim generator doesn't examine func return types when generating necessary imports
> --------------------------------------------------------------------------------------
>
>                 Key: BEAM-6577
>                 URL: https://issues.apache.org/jira/browse/BEAM-6577
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-go
>            Reporter: Tianyang Hu
>            Priority: P3
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> For the following function:
> {code:java}
> func myDoFn(s string) mypkg.MyType {...}
> {code}
> it's shim generated code doesn't import "mypkg", which leads to compilation error "undefined mypkg..."
> Seems that the func parser inspects only the input params, not return params: https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/util/starcgenx/starcgenx.go#L293
> Should we do the same for return types?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)