You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Bart Robeyns (JIRA)" <ji...@apache.org> on 2011/06/07 16:29:58 UTC
[jira] [Created] (HTTPCLIENT-1100) Missing Content-Length header
makes cached entry invalid
Missing Content-Length header makes cached entry invalid
--------------------------------------------------------
Key: HTTPCLIENT-1100
URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1100
Project: HttpComponents HttpClient
Issue Type: Bug
Components: Cache
Affects Versions: 4.1.1, 4.1.2, 4.2 Alpha1
Reporter: Bart Robeyns
Attachments: MissingContentLength.patch
A cached entry whose original response didn't carry a Content-Length header, should not be rejected for considered invalid because the length of its cached content is different from the non-existing Content-Length header value. The attached patch only verifies the lengths if the header was originally present.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] [Commented] (HTTPCLIENT-1100) Missing Content-Length header
makes cached entry invalid
Posted by "Jon Moore (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046603#comment-13046603 ]
Jon Moore commented on HTTPCLIENT-1100:
---------------------------------------
Also backported to the 4.1.x release branch.
> Missing Content-Length header makes cached entry invalid
> --------------------------------------------------------
>
> Key: HTTPCLIENT-1100
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1100
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: Cache
> Affects Versions: 4.1.1, 4.1.2, 4.2 Alpha1
> Reporter: Bart Robeyns
> Labels: cache, contentlength
> Fix For: 4.1.2, 4.2 Final
>
> Attachments: MissingContentLength.patch, MissingContentLength_with_licence.patch
>
>
> A cached entry whose original response didn't carry a Content-Length header, should not be rejected for considered invalid because the length of its cached content is different from the non-existing Content-Length header value. The attached patch only verifies the lengths if the header was originally present.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] [Commented] (HTTPCLIENT-1100) Missing Content-Length header
makes cached entry invalid
Posted by "Jon Moore (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046598#comment-13046598 ]
Jon Moore commented on HTTPCLIENT-1100:
---------------------------------------
Hi Bart, patch applied to trunk. I'll also work on backporting this to the other release branches.
> Missing Content-Length header makes cached entry invalid
> --------------------------------------------------------
>
> Key: HTTPCLIENT-1100
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1100
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: Cache
> Affects Versions: 4.1.1, 4.1.2, 4.2 Alpha1
> Reporter: Bart Robeyns
> Labels: cache, contentlength
> Attachments: MissingContentLength.patch, MissingContentLength_with_licence.patch
>
>
> A cached entry whose original response didn't carry a Content-Length header, should not be rejected for considered invalid because the length of its cached content is different from the non-existing Content-Length header value. The attached patch only verifies the lengths if the header was originally present.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] [Updated] (HTTPCLIENT-1100) Missing Content-Length header
makes cached entry invalid
Posted by "Jon Moore (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jon Moore updated HTTPCLIENT-1100:
----------------------------------
Fix Version/s: 4.2 Final
4.1.2
Assignee: Jon Moore
> Missing Content-Length header makes cached entry invalid
> --------------------------------------------------------
>
> Key: HTTPCLIENT-1100
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1100
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: Cache
> Affects Versions: 4.1.1, 4.1.2, 4.2 Alpha1
> Reporter: Bart Robeyns
> Assignee: Jon Moore
> Labels: cache, contentlength
> Fix For: 4.1.2, 4.2 Final
>
> Attachments: MissingContentLength.patch, MissingContentLength_with_licence.patch
>
>
> A cached entry whose original response didn't carry a Content-Length header, should not be rejected for considered invalid because the length of its cached content is different from the non-existing Content-Length header value. The attached patch only verifies the lengths if the header was originally present.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] [Commented] (HTTPCLIENT-1100) Missing Content-Length header
makes cached entry invalid
Posted by "Jon Moore (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046599#comment-13046599 ]
Jon Moore commented on HTTPCLIENT-1100:
---------------------------------------
...and, by the way, Bart, thanks very much for your contribution!
> Missing Content-Length header makes cached entry invalid
> --------------------------------------------------------
>
> Key: HTTPCLIENT-1100
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1100
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: Cache
> Affects Versions: 4.1.1, 4.1.2, 4.2 Alpha1
> Reporter: Bart Robeyns
> Labels: cache, contentlength
> Attachments: MissingContentLength.patch, MissingContentLength_with_licence.patch
>
>
> A cached entry whose original response didn't carry a Content-Length header, should not be rejected for considered invalid because the length of its cached content is different from the non-existing Content-Length header value. The attached patch only verifies the lengths if the header was originally present.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] [Updated] (HTTPCLIENT-1100) Missing Content-Length header
makes cached entry invalid
Posted by "Bart Robeyns (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bart Robeyns updated HTTPCLIENT-1100:
-------------------------------------
Attachment: MissingContentLength.patch
> Missing Content-Length header makes cached entry invalid
> --------------------------------------------------------
>
> Key: HTTPCLIENT-1100
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1100
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: Cache
> Affects Versions: 4.1.1, 4.1.2, 4.2 Alpha1
> Reporter: Bart Robeyns
> Labels: cache, contentlength
> Attachments: MissingContentLength.patch
>
>
> A cached entry whose original response didn't carry a Content-Length header, should not be rejected for considered invalid because the length of its cached content is different from the non-existing Content-Length header value. The attached patch only verifies the lengths if the header was originally present.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] [Updated] (HTTPCLIENT-1100) Missing Content-Length header
makes cached entry invalid
Posted by "Bart Robeyns (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bart Robeyns updated HTTPCLIENT-1100:
-------------------------------------
Attachment: MissingContentLength_with_licence.patch
with license granted to ASF
> Missing Content-Length header makes cached entry invalid
> --------------------------------------------------------
>
> Key: HTTPCLIENT-1100
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1100
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: Cache
> Affects Versions: 4.1.1, 4.1.2, 4.2 Alpha1
> Reporter: Bart Robeyns
> Labels: cache, contentlength
> Attachments: MissingContentLength.patch, MissingContentLength_with_licence.patch
>
>
> A cached entry whose original response didn't carry a Content-Length header, should not be rejected for considered invalid because the length of its cached content is different from the non-existing Content-Length header value. The attached patch only verifies the lengths if the header was originally present.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] [Resolved] (HTTPCLIENT-1100) Missing Content-Length header
makes cached entry invalid
Posted by "Jon Moore (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jon Moore resolved HTTPCLIENT-1100.
-----------------------------------
Resolution: Fixed
> Missing Content-Length header makes cached entry invalid
> --------------------------------------------------------
>
> Key: HTTPCLIENT-1100
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1100
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: Cache
> Affects Versions: 4.1.1, 4.1.2, 4.2 Alpha1
> Reporter: Bart Robeyns
> Assignee: Jon Moore
> Labels: cache, contentlength
> Fix For: 4.1.2, 4.2 Final
>
> Attachments: MissingContentLength.patch, MissingContentLength_with_licence.patch
>
>
> A cached entry whose original response didn't carry a Content-Length header, should not be rejected for considered invalid because the length of its cached content is different from the non-existing Content-Length header value. The attached patch only verifies the lengths if the header was originally present.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] [Commented] (HTTPCLIENT-1100) Missing Content-Length header
makes cached entry invalid
Posted by "Jon Moore (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046559#comment-13046559 ]
Jon Moore commented on HTTPCLIENT-1100:
---------------------------------------
By the way, I suppose this is presumed by my earlier response, but I agree this is a bug. The cache entry should only be considered invalid if there is a Content-Length header present and it does not match the length of the cached response body. If a Content-Length header is not present, then the entry should be presumed valid (at least per the sense of this test).
> Missing Content-Length header makes cached entry invalid
> --------------------------------------------------------
>
> Key: HTTPCLIENT-1100
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1100
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: Cache
> Affects Versions: 4.1.1, 4.1.2, 4.2 Alpha1
> Reporter: Bart Robeyns
> Labels: cache, contentlength
> Attachments: MissingContentLength.patch
>
>
> A cached entry whose original response didn't carry a Content-Length header, should not be rejected for considered invalid because the length of its cached content is different from the non-existing Content-Length header value. The attached patch only verifies the lengths if the header was originally present.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] [Commented] (HTTPCLIENT-1100) Missing Content-Length header
makes cached entry invalid
Posted by "Jon Moore (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046555#comment-13046555 ]
Jon Moore commented on HTTPCLIENT-1100:
---------------------------------------
Hi Bart,
Your patch looks great, although we need you to grant license to the ASF to include your patch. Can you either edit your attachment to grant ASF permission, or re-upload it with the proper permissions?
Thanks,
Jon
> Missing Content-Length header makes cached entry invalid
> --------------------------------------------------------
>
> Key: HTTPCLIENT-1100
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1100
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: Cache
> Affects Versions: 4.1.1, 4.1.2, 4.2 Alpha1
> Reporter: Bart Robeyns
> Labels: cache, contentlength
> Attachments: MissingContentLength.patch
>
>
> A cached entry whose original response didn't carry a Content-Length header, should not be rejected for considered invalid because the length of its cached content is different from the non-existing Content-Length header value. The attached patch only verifies the lengths if the header was originally present.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org