You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2017/07/11 11:11:41 UTC
Re: Review Request 60494: Expose LinuxLauncher cgroups helper.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60494/
-----------------------------------------------------------
(Updated July 11, 2017, 11:11 a.m.)
Review request for mesos, Qian Zhang and Jiang Yan Xu.
Bugs: MESOS-7675
https://issues.apache.org/jira/browse/MESOS-7675
Repository: mesos
Description
-------
Expose the LinuxLauncher cgroups helper to generate the cgroups
path from a container ID. This is needed by the `network/ports`
isolator.
Diffs (updated)
-----
src/slave/containerizer/mesos/linux_launcher.hpp e1525231e0a374bc044e929e82b8d051732e97cb
src/slave/containerizer/mesos/linux_launcher.cpp 1cea04edac8e0c4aea8c1c7d946b5065f3eac931
Diff: https://reviews.apache.org/r/60494/diff/3/
Changes: https://reviews.apache.org/r/60494/diff/2-3/
Testing
-------
make check (Fedora 26)
Thanks,
James Peach
Re: Review Request 60494: Exposed LinuxLauncher cgroups helper.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60494/#review182695
-----------------------------------------------------------
src/slave/containerizer/mesos/linux_launcher.hpp
Lines 64 (patched)
<https://reviews.apache.org/r/60494/#comment258679>
Better to move this method to the beginning together with `create()` and `available()`.
- Qian Zhang
On July 11, 2017, 7:11 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60494/
> -----------------------------------------------------------
>
> (Updated July 11, 2017, 7:11 p.m.)
>
>
> Review request for mesos, Qian Zhang and Jiang Yan Xu.
>
>
> Bugs: MESOS-7675
> https://issues.apache.org/jira/browse/MESOS-7675
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Expose the LinuxLauncher cgroups helper to generate the cgroups
> path from a container ID. This is needed by the `network/ports`
> isolator.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/linux_launcher.hpp e1525231e0a374bc044e929e82b8d051732e97cb
> src/slave/containerizer/mesos/linux_launcher.cpp 1cea04edac8e0c4aea8c1c7d946b5065f3eac931
>
>
> Diff: https://reviews.apache.org/r/60494/diff/8/
>
>
> Testing
> -------
>
> make check (Fedora 26)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 60494: Expose LinuxLauncher cgroups helper.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60494/#review180291
-----------------------------------------------------------
src/slave/containerizer/mesos/linux_launcher.cpp
Line 112 (original), 112-115 (patched)
<https://reviews.apache.org/r/60494/#comment255373>
Do we really need this wrapper? I see previously `LinuxLauncherProcess::cgroup()` was only called by `LinuxLauncherProcess::destroy()`, so what about just changing `LinuxLauncherProcess::destroy()` to call `LinuxLauncher::cgroup()` directly?
- Qian Zhang
On July 11, 2017, 7:11 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60494/
> -----------------------------------------------------------
>
> (Updated July 11, 2017, 7:11 p.m.)
>
>
> Review request for mesos, Qian Zhang and Jiang Yan Xu.
>
>
> Bugs: MESOS-7675
> https://issues.apache.org/jira/browse/MESOS-7675
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Expose the LinuxLauncher cgroups helper to generate the cgroups
> path from a container ID. This is needed by the `network/ports`
> isolator.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/linux_launcher.hpp e1525231e0a374bc044e929e82b8d051732e97cb
> src/slave/containerizer/mesos/linux_launcher.cpp 1cea04edac8e0c4aea8c1c7d946b5065f3eac931
>
>
> Diff: https://reviews.apache.org/r/60494/diff/3/
>
>
> Testing
> -------
>
> make check (Fedora 26)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 60494: Exposed LinuxLauncher cgroups helper.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60494/#review183434
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Aug. 14, 2017, 11:30 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60494/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2017, 11:30 p.m.)
>
>
> Review request for mesos, Qian Zhang and Jiang Yan Xu.
>
>
> Bugs: MESOS-7675
> https://issues.apache.org/jira/browse/MESOS-7675
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Expose the LinuxLauncher cgroups helper to generate the cgroups
> path from a container ID. This is needed by the `network/ports`
> isolator.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/linux_launcher.hpp e1525231e0a374bc044e929e82b8d051732e97cb
> src/slave/containerizer/mesos/linux_launcher.cpp 1cea04edac8e0c4aea8c1c7d946b5065f3eac931
>
>
> Diff: https://reviews.apache.org/r/60494/diff/9/
>
>
> Testing
> -------
>
> make check (Fedora 26)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 60494: Exposed LinuxLauncher cgroups helper.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60494/
-----------------------------------------------------------
(Updated Aug. 14, 2017, 11:30 p.m.)
Review request for mesos, Qian Zhang and Jiang Yan Xu.
Changes
-------
Rebased and addressed review feedback.
Bugs: MESOS-7675
https://issues.apache.org/jira/browse/MESOS-7675
Repository: mesos
Description
-------
Expose the LinuxLauncher cgroups helper to generate the cgroups
path from a container ID. This is needed by the `network/ports`
isolator.
Diffs (updated)
-----
src/slave/containerizer/mesos/linux_launcher.hpp e1525231e0a374bc044e929e82b8d051732e97cb
src/slave/containerizer/mesos/linux_launcher.cpp 1cea04edac8e0c4aea8c1c7d946b5065f3eac931
Diff: https://reviews.apache.org/r/60494/diff/9/
Changes: https://reviews.apache.org/r/60494/diff/8-9/
Testing
-------
make check (Fedora 26)
Thanks,
James Peach