[GitHub] wonook commented on a change in pull request #4: [NEMO-28] Javadoc and Travis

[GitBox <gi...@apache.org>]

wonook commented on a change in pull request #4: [NEMO-28] Javadoc and Travis
URL: https://github.com/apache/incubator-nemo/pull/4#discussion_r172510877
 
 

 ##########
 File path: common/src/main/java/edu/snu/nemo/common/test/ArgBuilder.java
 ##########
 @@ -19,12 +19,14 @@
 import java.util.Arrays;
 import java.util.List;
 import java.util.StringJoiner;
-import java.util.stream.Collectors;
+import java.util.stream.Stream;
 
 /**
  * Argument builder.
  */
 public final class ArgBuilder {
+  private static final List<List<String>> DEFAULT_ARGS = Arrays.asList(Arrays.asList("-executor_json",
 
 Review comment:
   I'd rather not fix it, since it would prevent users from running their applications using the `bin/run.sh` script without explicitly setting the `executor_json` parameter. This is indeed the default value for running integration tests, but not for all use cases.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services