[jira] [Commented] (FLINK-6173) flink-table not pack-in com.fasterxml.jackson.* in after #FLINK-5414

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-6173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16205887#comment-16205887 ] 

ASF GitHub Bot commented on FLINK-6173:
---------------------------------------

GitHub user twalthr opened a pull request:

    https://github.com/apache/flink/pull/4837

    [FLINK-6173] [table] Clean-up flink-table jar and dependencies

    ## What is the purpose of the change
    
    This PR cleans the `flink-table` dependencies almost entirely. The jar only contains files that are important. It shades everything except for Janino, because this causes problems. I think this PR makes the dependency management for users easier. The resulting jar looks like:
    
    <img width="514" alt="screen shot 2017-10-16 at 3 24 24 pm" src="https://user-images.githubusercontent.com/5746567/31614275-27bd5c74-b286-11e7-9d7b-113f6c4f7585.png">
    
    I ran some smaller test programs and could not spot any problems, feel free to test it as well.
    
    ## Brief change log
    
    Modification of the `flink-table` `pom.xml`.
    
    ## Verifying this change
    
    Run all tests and run an example program on the cluster.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): yes
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
      - The serializers: no)
      - The runtime per-record code paths (performance sensitive): no
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
    
    ## Documentation
    
      - Does this pull request introduce a new feature? no
      - If yes, how is the feature documented? not applicable
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/twalthr/flink FLINK-6173

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4837.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4837
    
----
commit e88670e6447cf3f3965222078ddc62b85fcb849c
Author: twalthr <tw...@apache.org>
Date:   2017-10-11T10:26:07Z

    [FLINK-6173] [table] Clean-up flink-table jar and dependencies

----


> flink-table not pack-in com.fasterxml.jackson.* in after #FLINK-5414
> --------------------------------------------------------------------
>
>                 Key: FLINK-6173
>                 URL: https://issues.apache.org/jira/browse/FLINK-6173
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API & SQL
>            Reporter: Zhenghua Gao
>            Assignee: Timo Walther
>            Priority: Blocker
>             Fix For: 1.4.0
>
>
> Currently, flink-table will pack-in com.fasterxml.jackson.* and rename them to org.apache.flink.shaded.calcite.com.fasterxml.jackson.*
> If a project depends on flink-table, and uses fasterxml as follows(function explain uses fasterxml indirectly):
> {code:title=WordCount.scala|borderStyle=solid}
> object WordCountWithTable {
>   def main(args: Array[String]): Unit = {
>     // set up execution environment
>     val env = ExecutionEnvironment.getExecutionEnvironment
>     val tEnv = TableEnvironment.getTableEnvironment(env)
>     val input = env.fromElements(WC("hello", 1), WC("hello", 1), WC("ciao", 1))
>     val expr = input.toTable(tEnv)
>     val result = expr
>       .groupBy('word)
>       .select('word, 'frequency.sum as 'frequency)
>       .filter('frequency === 2)
>     println(tEnv.explain(result))
>     result.toDataSet[WC].print()
>   }
>   case class WC(word: String, frequency: Long)
> }
> {code}
> It actually uses org.apache.flink.shaded.calcite.com.fasterxml.jackson.*
> I found after FLINK-5414,  flink-table didn't pack-in com.fasterxml.jackson.* and the project would throw class not found exception.
> {code:borderStyle=solid}
> Exception in thread "main" java.lang.NoClassDefFoundError: org/apache/flink/shaded/calcite/com/fasterxml/jackson/databind/ObjectMapper
> 	at org.apache.flink.table.explain.PlanJsonParser.getSqlExecutionPlan(PlanJsonParser.java:32)
> 	at org.apache.flink.table.api.BatchTableEnvironment.explain(BatchTableEnvironment.scala:143)
> 	at org.apache.flink.table.api.BatchTableEnvironment.explain(BatchTableEnvironment.scala:164)
> 	at org.apache.flink.quickstart.WordCountWithTable$.main(WordCountWithTable.scala:34)
> 	at org.apache.flink.quickstart.WordCountWithTable.main(WordCountWithTable.scala)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at java.lang.reflect.Method.invoke(Method.java:498)
> 	at com.intellij.rt.execution.application.AppMain.main(AppMain.java:144)
> Caused by: java.lang.ClassNotFoundException: org.apache.flink.shaded.calcite.com.fasterxml.jackson.databind.ObjectMapper
> 	at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
> 	at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
> 	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331)
> 	at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
> 	... 10 more
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)