You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2020/10/17 10:25:59 UTC

[GitHub] [zeppelin] yudhiwidyatama opened a new pull request #3946: [ZEPPELIN-4808] port changes from .sh files into functions.cmd,zeppel…

yudhiwidyatama opened a new pull request #3946:
URL: https://github.com/apache/zeppelin/pull/3946


   …in.cmd, interpreter.cmd, common.cmd
   
   ### What is this PR for?
   Enable windows users to run zeppelin 0.9.x by porting some changes from the linux files (functions.sh, zeppelin.sh, interpreter.sh, common.sh) into windows files (functions.cmd, zeppelin.cmd, interpreter.cmd, common.cmd)
   
   
   ### What type of PR is it?
   Bug Fix
   
   ### Todos
   * [ ] - Troubleshoot classloading issues
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/ZEPPELIN-4808
   
   ### How should this be tested?
   Start zeppelin on windows by running bin/zeppelin.cmd
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Does the licenses files need update?
   No
   * Is there breaking changes for older versions?
   No
   * Does this needs documentation?
   No
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] zjffdu commented on pull request #3946: [ZEPPELIN-4808] port changes from .sh files into functions.cmd,zeppel…

Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #3946:
URL: https://github.com/apache/zeppelin/pull/3946#issuecomment-723459523


   Great @yudhiwidyatama But it looks like only zeppelin-web's test is enabled, other module's test is not enabled. We should enable other module's test to make sure zeppelin works in windows


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] zjffdu edited a comment on pull request #3946: [ZEPPELIN-4808] port changes from .sh files into functions.cmd,zeppel…

Posted by GitBox <gi...@apache.org>.
zjffdu edited a comment on pull request #3946:
URL: https://github.com/apache/zeppelin/pull/3946#issuecomment-710837746


   @yudhiwidyatama  Thanks for the contribution on windows support, Could you enable windows CI via `.appveyor.yml` ? Otherwise we can not guarantee the windows support. 
   
   https://www.appveyor.com/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] zjffdu commented on pull request #3946: [ZEPPELIN-4808] port changes from .sh files into functions.cmd,zeppel…

Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #3946:
URL: https://github.com/apache/zeppelin/pull/3946#issuecomment-710837746


   Thanks for the contribution on windows support, Could you enable windows CI via `.appveyor.yml` ? Otherwise we can not guarantee the windows support. 
   
   https://www.appveyor.com/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] yudhiwidyatama commented on pull request #3946: [ZEPPELIN-4808] port changes from .sh files into functions.cmd,zeppel…

Posted by GitBox <gi...@apache.org>.
yudhiwidyatama commented on pull request #3946:
URL: https://github.com/apache/zeppelin/pull/3946#issuecomment-723020549


   Hi, I have add the appveyor yml and the appveyor build succeeded, the CI check shows green.. (see [appveyor build](https://ci.appveyor.com/project/ApacheSoftwareFoundation/zeppelin/builds/36021734) )  Anything else holding this PR being merged?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] zjffdu commented on pull request #3946: [ZEPPELIN-4808] port changes from .sh files into functions.cmd,zeppel…

Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #3946:
URL: https://github.com/apache/zeppelin/pull/3946#issuecomment-756506265


   ping @yudhiwidyatama Any update ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] yudhiwidyatama commented on pull request #3946: [ZEPPELIN-4808] port changes from .sh files into functions.cmd,zeppel…

Posted by GitBox <gi...@apache.org>.
yudhiwidyatama commented on pull request #3946:
URL: https://github.com/apache/zeppelin/pull/3946#issuecomment-757081496


   Hi,
   I managed to get many appveyor tests running in my other branch but still a
   long way to go :
   
   
   [INFO]
   23109
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23109>INFO]
   Zeppelin ........................................... SUCCESS [ 3.281 s]
   23110
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23110>[INFO]
   Zeppelin: Common ................................... SUCCESS [ 1.203 s]
   23111
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23111>[INFO]
   Zeppelin: Interpreter .............................. SUCCESS [ 37.497 s]
   23112
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23112>[INFO]
   Zeppelin: Interpreter Shaded ....................... SUCCESS [ 32.844 s]
   23113
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23113>[INFO]
   Zeppelin: Interpreter Parent ....................... SUCCESS [ 0.547 s]
   23114
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23114>[INFO]
   Zeppelin: Markdown interpreter ..................... SUCCESS [ 7.312 s]
   23115
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23115>[INFO]
   Zeppelin: Jupyter Support .......................... SUCCESS [ 1.922 s]
   23116
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23116>[INFO]
   Zeppelin: Zengine .................................. SUCCESS [07:17 min]
   23117
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23117>[INFO]
   Zeppelin: Display system apis ...................... SUCCESS [ 3.813 s]
   23118
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23118>[INFO]
   Zeppelin: Jupyter Interpreter ...................... FAILURE [ 25.128 s]
   23119
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23119>[INFO]
   Zeppelin: Jupyter Interpreter Shaded ............... SKIPPED
   23120
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23120>[INFO]
   Zeppelin: R ........................................ SKIPPED
   23121
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23121>[INFO]
   Zeppelin: Kotlin interpreter ....................... SKIPPED
   23122
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23122>[INFO]
   Zeppelin: Spark Parent ............................. SKIPPED
   23123
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23123>[INFO]
   Zeppelin: Spark Shims .............................. SKIPPED
   23124
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23124>[INFO]
   Zeppelin: Spark1 Shims ............................. SKIPPED
   23125
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23125>[INFO]
   Zeppelin: Spark2 Shims ............................. SKIPPED
   23126
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23126>[INFO]
   Zeppelin: Spark3 Shims ............................. SKIPPED
   23127
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23127>[INFO]
   Zeppelin: Python interpreter ....................... SKIPPED
   23128
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23128>[INFO]
   Zeppelin: Spark Interpreter ........................ SKIPPED
   23129
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23129>[INFO]
   Zeppelin: Spark Scala Parent ....................... SKIPPED
   23130
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23130>[INFO]
   Zeppelin: Spark Interpreter Scala_2.10 ............. SKIPPED
   23131
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23131>[INFO]
   Zeppelin: Spark Interpreter Scala_2.11 ............. SKIPPED
   23132
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23132>[INFO]
   Zeppelin: Spark Interpreter Scala_2.12 ............. SKIPPED
   23133
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23133>[INFO]
   Zeppelin: Spark dependencies ....................... SKIPPED
   23134
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23134>[INFO]
   Zeppelin: Shell interpreter ........................ SKIPPED
   23135
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23135>[INFO]
   Zeppelin: Angular interpreter ...................... SKIPPED
   23136
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23136>[INFO]
   Zeppelin: web Application .......................... SKIPPED
   23137
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23137>[INFO]
   Zeppelin: Server ................................... SKIPPED
   23138
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23138>
   
   On Fri, Jan 8, 2021 at 9:28 AM Jeff Zhang <no...@github.com> wrote:
   
   > ping @yudhiwidyatama <https://github.com/yudhiwidyatama> Any update ?
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/zeppelin/pull/3946#issuecomment-756506265>, or
   > unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AAEU53QRAVH2Y4HY7FJHMB3SYZUUFANCNFSM4SUITTKA>
   > .
   >
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] yudhiwidyatama commented on pull request #3946: [ZEPPELIN-4808] port changes from .sh files into functions.cmd,zeppel…

Posted by GitBox <gi...@apache.org>.
yudhiwidyatama commented on pull request #3946:
URL: https://github.com/apache/zeppelin/pull/3946#issuecomment-727804768


   Hi, I tried to enable additional 2 tests, many tests has errors when running under Windows, do I need to fix them all in this one PR ?
   
   ~/Downloads/zepp-log7.txt:10371: [00:14:40] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.188 sec - in org.apache.zeppelin.helium.HeliumLocalRegistryTest
   ~/Downloads/zepp-log7.txt:10384: [00:14:43] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.694 sec - in org.apache.zeppelin.helium.HeliumOnlineRegistryTest
   ~/Downloads/zepp-log7.txt:10514: [00:14:43] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.265 sec - in org.apache.zeppelin.helium.HeliumTest
   ~/Downloads/zepp-log7.txt:10666: [00:14:47] Tests run: 4, Failures: 0, Errors: 4, Skipped: 0, Time elapsed: 3.04 sec <<< FAILURE! - in org.apache.zeppelin.interpreter.ConfInterpreterTest
   ~/Downloads/zepp-log7.txt:10800: [00:14:51] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.863 sec - in org.apache.zeppelin.interpreter.install.InstallInterpreterTest
   ~/Downloads/zepp-log7.txt:10903: [00:14:53] Tests run: 5, Failures: 0, Errors: 4, Skipped: 0, Time elapsed: 1.351 sec <<< FAILURE! - in org.apache.zeppelin.interpreter.InterpreterFactoryTest
   ~/Downloads/zepp-log7.txt:11135: [00:14:55] Tests run: 21, Failures: 0, Errors: 20, Skipped: 0, Time elapsed: 1.307 sec <<< FAILURE! - in org.apache.zeppelin.interpreter.InterpreterSettingManagerTest
   ~/Downloads/zepp-log7.txt:11977: [00:14:56] Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.5 sec - in org.apache.zeppelin.interpreter.InterpreterSettingTest
   ~/Downloads/zepp-log7.txt:12023: [00:15:01] Tests run: 7, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 4.429 sec <<< FAILURE! - in org.apache.zeppelin.interpreter.launcher.SparkInterpreterLauncherTest
   ~/Downloads/zepp-log7.txt:12048: [00:15:02] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.407 sec - in org.apache.zeppelin.interpreter.launcher.StandardInterpreterLauncherTest
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] yudhiwidyatama commented on pull request #3946: [ZEPPELIN-4808] port changes from .sh files into functions.cmd,zeppel…

Posted by GitBox <gi...@apache.org>.
yudhiwidyatama commented on pull request #3946:
URL: https://github.com/apache/zeppelin/pull/3946#issuecomment-757081496


   Hi,
   I managed to get many appveyor tests running in my other branch but still a
   long way to go :
   
   
   [INFO]
   23109
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23109>INFO]
   Zeppelin ........................................... SUCCESS [ 3.281 s]
   23110
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23110>[INFO]
   Zeppelin: Common ................................... SUCCESS [ 1.203 s]
   23111
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23111>[INFO]
   Zeppelin: Interpreter .............................. SUCCESS [ 37.497 s]
   23112
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23112>[INFO]
   Zeppelin: Interpreter Shaded ....................... SUCCESS [ 32.844 s]
   23113
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23113>[INFO]
   Zeppelin: Interpreter Parent ....................... SUCCESS [ 0.547 s]
   23114
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23114>[INFO]
   Zeppelin: Markdown interpreter ..................... SUCCESS [ 7.312 s]
   23115
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23115>[INFO]
   Zeppelin: Jupyter Support .......................... SUCCESS [ 1.922 s]
   23116
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23116>[INFO]
   Zeppelin: Zengine .................................. SUCCESS [07:17 min]
   23117
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23117>[INFO]
   Zeppelin: Display system apis ...................... SUCCESS [ 3.813 s]
   23118
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23118>[INFO]
   Zeppelin: Jupyter Interpreter ...................... FAILURE [ 25.128 s]
   23119
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23119>[INFO]
   Zeppelin: Jupyter Interpreter Shaded ............... SKIPPED
   23120
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23120>[INFO]
   Zeppelin: R ........................................ SKIPPED
   23121
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23121>[INFO]
   Zeppelin: Kotlin interpreter ....................... SKIPPED
   23122
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23122>[INFO]
   Zeppelin: Spark Parent ............................. SKIPPED
   23123
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23123>[INFO]
   Zeppelin: Spark Shims .............................. SKIPPED
   23124
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23124>[INFO]
   Zeppelin: Spark1 Shims ............................. SKIPPED
   23125
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23125>[INFO]
   Zeppelin: Spark2 Shims ............................. SKIPPED
   23126
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23126>[INFO]
   Zeppelin: Spark3 Shims ............................. SKIPPED
   23127
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23127>[INFO]
   Zeppelin: Python interpreter ....................... SKIPPED
   23128
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23128>[INFO]
   Zeppelin: Spark Interpreter ........................ SKIPPED
   23129
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23129>[INFO]
   Zeppelin: Spark Scala Parent ....................... SKIPPED
   23130
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23130>[INFO]
   Zeppelin: Spark Interpreter Scala_2.10 ............. SKIPPED
   23131
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23131>[INFO]
   Zeppelin: Spark Interpreter Scala_2.11 ............. SKIPPED
   23132
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23132>[INFO]
   Zeppelin: Spark Interpreter Scala_2.12 ............. SKIPPED
   23133
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23133>[INFO]
   Zeppelin: Spark dependencies ....................... SKIPPED
   23134
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23134>[INFO]
   Zeppelin: Shell interpreter ........................ SKIPPED
   23135
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23135>[INFO]
   Zeppelin: Angular interpreter ...................... SKIPPED
   23136
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23136>[INFO]
   Zeppelin: web Application .......................... SKIPPED
   23137
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23137>[INFO]
   Zeppelin: Server ................................... SKIPPED
   23138
   <https://ci.appveyor.com/project/yudhiwidyatama/zeppelin/builds/36553023#L23138>
   
   On Fri, Jan 8, 2021 at 9:28 AM Jeff Zhang <no...@github.com> wrote:
   
   > ping @yudhiwidyatama <https://github.com/yudhiwidyatama> Any update ?
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/zeppelin/pull/3946#issuecomment-756506265>, or
   > unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AAEU53QRAVH2Y4HY7FJHMB3SYZUUFANCNFSM4SUITTKA>
   > .
   >
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] yudhiwidyatama commented on pull request #3946: [ZEPPELIN-4808] port changes from .sh files into functions.cmd,zeppel…

Posted by GitBox <gi...@apache.org>.
yudhiwidyatama commented on pull request #3946:
URL: https://github.com/apache/zeppelin/pull/3946#issuecomment-711579148


   Hi, I am trying to do just that, but somehow got hit by the 60 minute time
   limit in the Appveyor Cloud . The caching doesn't work either (appveyor
   rejects cache data if more than 1 GB).
   It might be one of the maven build phases got stuck, still need to
   troubleshoot more..
   On Sat, Oct 17, 2020 at 6:22 PM Jeff Zhang <no...@github.com> wrote:
   
   > Thanks for the contribution on windows support, Could you enable windows
   > CI via .appveyor.yml ? Otherwise we can not guarantee the windows support.
   >
   > https://www.appveyor.com/
   >
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/zeppelin/pull/3946#issuecomment-710837746>, or
   > unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AAEU53QK4MLA7D5POWOEQQDSLF47TANCNFSM4SUITTKA>
   > .
   >
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] zjffdu commented on pull request #3946: [ZEPPELIN-4808] port changes from .sh files into functions.cmd,zeppel…

Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #3946:
URL: https://github.com/apache/zeppelin/pull/3946#issuecomment-718342903


   Thanks for the update and hard work @yudhiwidyatama 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] zjffdu commented on pull request #3946: [ZEPPELIN-4808] port changes from .sh files into functions.cmd,zeppel…

Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #3946:
URL: https://github.com/apache/zeppelin/pull/3946#issuecomment-727859631


   @yudhiwidyatama Have you verify zeppelin on windows manually ? If so, you can disable these test on widows temporally and fix them via following PRs


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] zjffdu edited a comment on pull request #3946: [ZEPPELIN-4808] port changes from .sh files into functions.cmd,zeppel…

Posted by GitBox <gi...@apache.org>.
zjffdu edited a comment on pull request #3946:
URL: https://github.com/apache/zeppelin/pull/3946#issuecomment-710837746


   @yudhiwidyatama  Thanks for the contribution on windows support, Could you also help enable windows CI via `.appveyor.yml` ? Otherwise we can not guarantee the windows support. 
   
   https://www.appveyor.com/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org