You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "shashbha14 (via GitHub)" <gi...@apache.org> on 2026/02/28 13:19:10 UTC

[PR] Add "Partitioned Runs" tab for consumer DAGs with PartitionedAssetTimetable [airflow]

shashbha14 opened a new pull request, #62631:
URL: https://github.com/apache/airflow/pull/62631

   Summary
   Adds the missing "Partitioned Runs" tab on the DAG detail UI for consumer DAGs that use `PartitionedAssetTimetable`, so users can view asset-triggered runs separately.
   
   1.Changes
   
   - Dag.tsx**: Show a "Partitioned Runs" tab when `dag.timetable_summary === "Partitioned Asset"` (between Runs and Tasks)
   - PartitionedRuns component**: New view that filters DAG runs by `run_type=asset_triggered` and reuses the existing `DagRuns` table
   - router.tsx**: Add route `partitioned_runs` under `dags/:dagId`
   - dag.json**: Add translation key `partitionedRuns: "Partitioned Runs"`
   
   2. How to test
   
   1. Create a consumer DAG using `PartitionedAssetTimetable` (see issue for example DAG)
   2. Open the DAG detail page
   3. The "Partitioned Runs" tab should appear between "Runs" and "Tasks"
   4. Clicking it should show only asset-triggered runs
   
   Fixes #62564


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix #62631: Auto-filter Runs tab for PartitionedAssetTimetable DAGs [airflow]

Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun closed pull request #62631: Fix #62631: Auto-filter Runs tab for PartitionedAssetTimetable DAGs
URL: https://github.com/apache/airflow/pull/62631


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add "Partitioned Runs" tab for consumer DAGs with PartitionedAssetTimetable [airflow]

Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #62631:
URL: https://github.com/apache/airflow/pull/62631#discussion_r2896310291


##########
airflow-core/src/airflow/ui/src/pages/Dag/Dag.tsx:
##########
@@ -106,6 +93,32 @@ export const Dag = () => {
     },
   );
 
+  const isPartitionedAssetDag = dag?.timetable_summary === "Partitioned Asset";
+  const tabs = useMemo(
+    () => [
+      { icon: <LuChartColumn />, label: translate("tabs.overview"), value: "" },
+      { icon: <FiBarChart />, label: translate("tabs.runs"), value: "runs" },
+      ...(isPartitionedAssetDag
+        ? [
+            {
+              icon: <FiLayers />,
+              label: translate("tabs.partitionedRuns"),
+              value: "partitioned_runs",
+            },
+          ]
+        : []),
+      { icon: <TaskIcon />, label: translate("tabs.tasks"), value: "tasks" },
+      { icon: <FiCalendar />, label: translate("tabs.calendar"), value: "calendar" },
+      { icon: <FiUser />, label: translate("tabs.requiredActions"), value: "required_actions" },
+      { icon: <RiArrowGoBackFill />, label: translate("tabs.backfills"), value: "backfills" },
+      { icon: <MdOutlineEventNote />, label: translate("tabs.auditLog"), value: "events" },
+      { icon: <FiCode />, label: translate("tabs.code"), value: "code" },
+      { icon: <MdDetails />, label: translate("tabs.details"), value: "details" },
+      ...externalTabs,
+    ],
+    [translate, isPartitionedAssetDag, externalTabs]
+  );

Review Comment:
   You don't need to useMemo, the react-compiler will do that for you.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix #62631: Auto-filter Runs tab for PartitionedAssetTimetable DAGs [airflow]

Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #62631:
URL: https://github.com/apache/airflow/pull/62631#issuecomment-4031595561

   Closing, PRs from this users are ignoring review comments, not fixing underlying problems they report to fix or complete AI hallucination.
   
   Please refrain from opening such PRs, it's not helping the project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add "Partitioned Runs" tab for consumer DAGs with PartitionedAssetTimetable [airflow]

Posted by "shashbha14 (via GitHub)" <gi...@apache.org>.
shashbha14 commented on code in PR #62631:
URL: https://github.com/apache/airflow/pull/62631#discussion_r2899321027


##########
airflow-core/src/airflow/ui/src/pages/Dag/Dag.tsx:
##########
@@ -106,6 +93,32 @@ export const Dag = () => {
     },
   );
 
+  const isPartitionedAssetDag = dag?.timetable_summary === "Partitioned Asset";
+  const tabs = useMemo(
+    () => [
+      { icon: <LuChartColumn />, label: translate("tabs.overview"), value: "" },
+      { icon: <FiBarChart />, label: translate("tabs.runs"), value: "runs" },
+      ...(isPartitionedAssetDag
+        ? [
+            {
+              icon: <FiLayers />,
+              label: translate("tabs.partitionedRuns"),
+              value: "partitioned_runs",
+            },
+          ]
+        : []),
+      { icon: <TaskIcon />, label: translate("tabs.tasks"), value: "tasks" },
+      { icon: <FiCalendar />, label: translate("tabs.calendar"), value: "calendar" },
+      { icon: <FiUser />, label: translate("tabs.requiredActions"), value: "required_actions" },
+      { icon: <RiArrowGoBackFill />, label: translate("tabs.backfills"), value: "backfills" },
+      { icon: <MdOutlineEventNote />, label: translate("tabs.auditLog"), value: "events" },
+      { icon: <FiCode />, label: translate("tabs.code"), value: "code" },
+      { icon: <MdDetails />, label: translate("tabs.details"), value: "details" },
+      ...externalTabs,
+    ],
+    [translate, isPartitionedAssetDag, externalTabs]
+  );

Review Comment:
   Addressed reviewer feedback:
     - Removed the dedicated "Partitioned Runs" tab
     - Instead, auto-apply run_type=asset_triggered filter on the existing Runs tab when the DAG uses
       PartitionedAssetTimetable
     - Removed useMemo per react-compiler guidance



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org