You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/07/14 09:23:05 UTC
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #10925: [Feature][Task Plugin] Enable users to switch endpoints in zeppelin tasks
EricGao888 commented on code in PR #10925:
URL: https://github.com/apache/dolphinscheduler/pull/10925#discussion_r920945661
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-zeppelin/src/main/java/org/apache/dolphinscheduler/plugin/task/zeppelin/ZeppelinParameters.java:
##########
@@ -32,6 +32,7 @@ public class ZeppelinParameters extends AbstractParameters {
*/
private String noteId;
private String paragraphId;
+ private String restEndpoint;
Review Comment:
Sure, I will add a check here
```java
@Override
public boolean checkParameters() {
return StringUtils.isNotEmpty(this.noteId);
}
```
Thx~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org