You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/19 07:58:03 UTC
[GitHub] [airflow] MichaelChirico opened a new pull request #7463:
[AIRFLOW-XXXX] clarify dag_id parameter
MichaelChirico opened a new pull request #7463: [AIRFLOW-XXXX] clarify dag_id parameter
URL: https://github.com/apache/airflow/pull/7463
Re-filing #7462 here:
I spent a while chasing this just now, wondering whether `:` is valid before finding `validate_key()` in helpers.
I think it's helpful to surface this here directly.
Trivial change so eschewing the other formality required in the PR template
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] boring-cyborg[bot] commented on issue #7463:
[AIRFLOW-XXXX] clarify dag_id parameter
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #7463: [AIRFLOW-XXXX] clarify dag_id parameter
URL: https://github.com/apache/airflow/pull/7463#issuecomment-589893146
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on issue #7463: [AIRFLOW-XXXX] clarify
dag_id parameter
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #7463: [AIRFLOW-XXXX] clarify dag_id parameter
URL: https://github.com/apache/airflow/pull/7463#issuecomment-589893190
Thanks @MichaelChirico 🎉
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] zhongjiajie commented on issue #7463: [AIRFLOW-XXXX]
clarify dag_id parameter
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #7463: [AIRFLOW-XXXX] clarify dag_id parameter
URL: https://github.com/apache/airflow/pull/7463#issuecomment-588573087
@MichaelChirico Not only your PR title, but also your git commit message.
you could change and then force push to restart validator
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil merged pull request #7463: [AIRFLOW-XXXX] clarify
dag_id parameter
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #7463: [AIRFLOW-XXXX] clarify dag_id parameter
URL: https://github.com/apache/airflow/pull/7463
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] MichaelChirico commented on issue #7463: [AIRFLOW-XXXX]
clarify dag_id parameter
Posted by GitBox <gi...@apache.org>.
MichaelChirico commented on issue #7463: [AIRFLOW-XXXX] clarify dag_id parameter
URL: https://github.com/apache/airflow/pull/7463#issuecomment-589893949
Of course now that it's merged I just noticed that `exclusively` is used twice 🤦♂ @kaxil
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on issue #7463: [AIRFLOW-XXXX] clarify
dag_id parameter
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #7463: [AIRFLOW-XXXX] clarify dag_id parameter
URL: https://github.com/apache/airflow/pull/7463#issuecomment-589894272
> Of course now that it's merged I just noticed that `exclusively` is used twice 🤦♂ @kaxil
I missed it as well :) Want to submit another PR fixing it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] MichaelChirico commented on issue #7463: [AIRFLOW-XXXX]
clarify dag_id parameter
Posted by GitBox <gi...@apache.org>.
MichaelChirico commented on issue #7463: [AIRFLOW-XXXX] clarify dag_id parameter
URL: https://github.com/apache/airflow/pull/7463#issuecomment-589153238
failure seems unrelated:
>The job exceeded the maximum time limit for jobs, and has been terminated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services