You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Niall Pemberton <ni...@gmail.com> on 2008/03/19 12:54:14 UTC
Re: svn commit: r638703 - in /commons/proper/lang/branches/LANG_POST_2_4/src: java/org/apache/commons/lang/ test/org/apache/commons/lang/
Adding rather than copying looses all the svn history of these files
which is a big mistake IMO.
Niall
On Wed, Mar 19, 2008 at 4:31 AM, <mb...@apache.org> wrote:
> Author: mbenson
> Date: Tue Mar 18 21:31:46 2008
> New Revision: 638703
>
> URL: http://svn.apache.org/viewvc?rev=638703&view=rev
> Log:
> [LANG-416] import MethodUtils, ConstructorUtils from [beanutils]
>
> Added:
> commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/ConstructorUtils.java (with props)
> commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/MemberUtils.java (with props)
> commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/MethodUtils.java (with props)
> commons/proper/lang/branches/LANG_POST_2_4/src/test/org/apache/commons/lang/ConstructorUtilsTest.java (with props)
> commons/proper/lang/branches/LANG_POST_2_4/src/test/org/apache/commons/lang/MethodUtilsTest.java (with props)
> Modified:
> commons/proper/lang/branches/LANG_POST_2_4/src/test/org/apache/commons/lang/LangTestSuite.java
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [lang] and the [reflect] project
Posted by Matt Benson <gu...@yahoo.com>.
--- Stephen Colebourne <sc...@btopenworld.com>
wrote:
> > This brings us
> > back, however, to the question of whether
> [reflect]
> > should be resurrected. My personal feeling is
> that
> > the scope of [reflect] as repository for "stuff to
> > make it easier to work with java.lang.reflect" is
> so
> > small and has so much overlap with [lang], that
> it's
> > not really worth it. The namespace of
> > java.lang.reflect once again emphasizes that this
> > stuff is at best a subset of functionality that
> makes
> > sense in [lang].
>
> My point was not really about reviving [reflect],
> but taking the code
> from it. I believe that the code was actually quite
> good and covered a
> lot of corner cases before it went dormant.
>
Cool. I'll have a look; I think this puts most of us,
if not on the same page, at least in the same chapter.
Thanks!
-Matt
> Stephen
>
>
>
>
---------------------------------------------------------------------
> To unsubscribe, e-mail:
> dev-unsubscribe@commons.apache.org
> For additional commands, e-mail:
> dev-help@commons.apache.org
>
>
____________________________________________________________________________________
Be a better friend, newshound, and
know-it-all with Yahoo! Mobile. Try it now. http://mobile.yahoo.com/;_ylt=Ahu06i62sR8HDtDypao8Wcj9tAcJ
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[lang] and the [reflect] project
Posted by Stephen Colebourne <sc...@btopenworld.com>.
> This brings us
> back, however, to the question of whether [reflect]
> should be resurrected. My personal feeling is that
> the scope of [reflect] as repository for "stuff to
> make it easier to work with java.lang.reflect" is so
> small and has so much overlap with [lang], that it's
> not really worth it. The namespace of
> java.lang.reflect once again emphasizes that this
> stuff is at best a subset of functionality that makes
> sense in [lang].
My point was not really about reviving [reflect], but taking the code
from it. I believe that the code was actually quite good and covered a
lot of corner cases before it went dormant.
Stephen
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r638703 - in /commons/proper/lang/branches/LANG_POST_2_4/src: java/org/apache/commons/lang/ test/org/apache/commons/lang/
Posted by Matt Benson <gu...@yahoo.com>.
--- Niall Pemberton <ni...@gmail.com> wrote:
> On Wed, Mar 19, 2008 at 2:42 PM, Matt Benson
> <gu...@yahoo.com> wrote:
> >
> > --- Rahul Akolkar <ra...@gmail.com>
> wrote:
> >
> > > On 3/19/08, Matt Benson <gu...@yahoo.com>
> > > wrote:
> > > >
> > > > --- Niall Pemberton
> <ni...@gmail.com>
> > > wrote:
> > > >
> > > > > Adding rather than copying looses all the
> svn
> > > > > history of these files
> > > > > which is a big mistake IMO.
> > > >
> > > >
> > > > Point taken; I wasn't thinking about that.
> :)
> > > > However, since we've not yet agreed on the
> final
> > > home
> > > > for this stuff, I'm going to leave as-is for
> now.
> > > If
> > > > we decide to merge this stuff back to trunk
> (this
> > > is
> > > > intended, after all, to be only a temporary
> > > branch),
> > > > we can copy the (non-compiling) BeanUtils
> > > versions in,
> > > > then Lang-ify by committing the branch
> versions.
> > > >
> > > <snip/>
> > >
> > > This will make it hard to carry over the
> history
> > > between now and then, if any.
> >
> > Okay. You guys win. I'll try to get to it
> today.
>
> Great, thanks :)
>
> Another suggestion - perhaps these things should go
> in a
> "org.apache.commons.lang.reflect" package? It would
> tie up nicely with
> the java.lang.reflect and package all these related
> impls. together.
>
I agree that the symmetry with java.lang.reflect is
nice, so I'll go ahead and do this. This brings us
back, however, to the question of whether [reflect]
should be resurrected. My personal feeling is that
the scope of [reflect] as repository for "stuff to
make it easier to work with java.lang.reflect" is so
small and has so much overlap with [lang], that it's
not really worth it. The namespace of
java.lang.reflect once again emphasizes that this
stuff is at best a subset of functionality that makes
sense in [lang].
In contrast, Morph's "reflector" facet would IMHO make
a nice standalone Commons component as a/the new take
on the bean/dynabean/etc. facilities of [beanutils].
Similar to [clazz] but far less complicated IMO, and
therefore hopefully more likely to survive.
-Matt
> Niall
>
> > -Matt
> >
> >
> > >
> > > -Rahul
> > >
> > >
> > >
> > > > Also, I didn't reuse the old tests at all,
> but if
> > > you
> > > > think it's important that we do so let me
> know.
> > > >
> > > > -Matt
> > > >
> > > <snap/>
>
>
---------------------------------------------------------------------
> To unsubscribe, e-mail:
> dev-unsubscribe@commons.apache.org
> For additional commands, e-mail:
> dev-help@commons.apache.org
>
>
____________________________________________________________________________________
Never miss a thing. Make Yahoo your home page.
http://www.yahoo.com/r/hs
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r638703 - in /commons/proper/lang/branches/LANG_POST_2_4/src: java/org/apache/commons/lang/ test/org/apache/commons/lang/
Posted by Niall Pemberton <ni...@gmail.com>.
On Wed, Mar 19, 2008 at 2:42 PM, Matt Benson <gu...@yahoo.com> wrote:
>
> --- Rahul Akolkar <ra...@gmail.com> wrote:
>
> > On 3/19/08, Matt Benson <gu...@yahoo.com>
> > wrote:
> > >
> > > --- Niall Pemberton <ni...@gmail.com>
> > wrote:
> > >
> > > > Adding rather than copying looses all the svn
> > > > history of these files
> > > > which is a big mistake IMO.
> > >
> > >
> > > Point taken; I wasn't thinking about that. :)
> > > However, since we've not yet agreed on the final
> > home
> > > for this stuff, I'm going to leave as-is for now.
> > If
> > > we decide to merge this stuff back to trunk (this
> > is
> > > intended, after all, to be only a temporary
> > branch),
> > > we can copy the (non-compiling) BeanUtils
> > versions in,
> > > then Lang-ify by committing the branch versions.
> > >
> > <snip/>
> >
> > This will make it hard to carry over the history
> > between now and then, if any.
>
> Okay. You guys win. I'll try to get to it today.
Great, thanks :)
Another suggestion - perhaps these things should go in a
"org.apache.commons.lang.reflect" package? It would tie up nicely with
the java.lang.reflect and package all these related impls. together.
Niall
> -Matt
>
>
> >
> > -Rahul
> >
> >
> >
> > > Also, I didn't reuse the old tests at all, but if
> > you
> > > think it's important that we do so let me know.
> > >
> > > -Matt
> > >
> > <snap/>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r638703 - in /commons/proper/lang/branches/LANG_POST_2_4/src: java/org/apache/commons/lang/ test/org/apache/commons/lang/
Posted by Matt Benson <gu...@yahoo.com>.
--- Rahul Akolkar <ra...@gmail.com> wrote:
> On 3/19/08, Matt Benson <gu...@yahoo.com>
> wrote:
> >
> > --- Niall Pemberton <ni...@gmail.com>
> wrote:
> >
> > > Adding rather than copying looses all the svn
> > > history of these files
> > > which is a big mistake IMO.
> >
> >
> > Point taken; I wasn't thinking about that. :)
> > However, since we've not yet agreed on the final
> home
> > for this stuff, I'm going to leave as-is for now.
> If
> > we decide to merge this stuff back to trunk (this
> is
> > intended, after all, to be only a temporary
> branch),
> > we can copy the (non-compiling) BeanUtils
> versions in,
> > then Lang-ify by committing the branch versions.
> >
> <snip/>
>
> This will make it hard to carry over the history
> between now and then, if any.
Okay. You guys win. I'll try to get to it today.
-Matt
>
> -Rahul
>
>
>
> > Also, I didn't reuse the old tests at all, but if
> you
> > think it's important that we do so let me know.
> >
> > -Matt
> >
> <snap/>
>
>
---------------------------------------------------------------------
> To unsubscribe, e-mail:
> dev-unsubscribe@commons.apache.org
> For additional commands, e-mail:
> dev-help@commons.apache.org
>
>
____________________________________________________________________________________
Never miss a thing. Make Yahoo your home page.
http://www.yahoo.com/r/hs
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r638703 - in /commons/proper/lang/branches/LANG_POST_2_4/src: java/org/apache/commons/lang/ test/org/apache/commons/lang/
Posted by Rahul Akolkar <ra...@gmail.com>.
On 3/19/08, Matt Benson <gu...@yahoo.com> wrote:
>
> --- Niall Pemberton <ni...@gmail.com> wrote:
>
> > Adding rather than copying looses all the svn
> > history of these files
> > which is a big mistake IMO.
>
>
> Point taken; I wasn't thinking about that. :)
> However, since we've not yet agreed on the final home
> for this stuff, I'm going to leave as-is for now. If
> we decide to merge this stuff back to trunk (this is
> intended, after all, to be only a temporary branch),
> we can copy the (non-compiling) BeanUtils versions in,
> then Lang-ify by committing the branch versions.
>
<snip/>
This will make it hard to carry over the history between now and then, if any.
-Rahul
> Also, I didn't reuse the old tests at all, but if you
> think it's important that we do so let me know.
>
> -Matt
>
<snap/>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r638703 - in /commons/proper/lang/branches/LANG_POST_2_4/src: java/org/apache/commons/lang/ test/org/apache/commons/lang/
Posted by Matt Benson <gu...@yahoo.com>.
--- Niall Pemberton <ni...@gmail.com> wrote:
> Adding rather than copying looses all the svn
> history of these files
> which is a big mistake IMO.
Point taken; I wasn't thinking about that. :)
However, since we've not yet agreed on the final home
for this stuff, I'm going to leave as-is for now. If
we decide to merge this stuff back to trunk (this is
intended, after all, to be only a temporary branch),
we can copy the (non-compiling) BeanUtils versions in,
then Lang-ify by committing the branch versions.
Also, I didn't reuse the old tests at all, but if you
think it's important that we do so let me know.
-Matt
>
> Niall
>
> On Wed, Mar 19, 2008 at 4:31 AM,
> <mb...@apache.org> wrote:
> > Author: mbenson
> > Date: Tue Mar 18 21:31:46 2008
> > New Revision: 638703
> >
> > URL:
> http://svn.apache.org/viewvc?rev=638703&view=rev
> > Log:
> > [LANG-416] import MethodUtils, ConstructorUtils
> from [beanutils]
> >
> > Added:
> >
>
commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/ConstructorUtils.java
> (with props)
> >
>
commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/MemberUtils.java
> (with props)
> >
>
commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/MethodUtils.java
> (with props)
> >
>
commons/proper/lang/branches/LANG_POST_2_4/src/test/org/apache/commons/lang/ConstructorUtilsTest.java
> (with props)
> >
>
commons/proper/lang/branches/LANG_POST_2_4/src/test/org/apache/commons/lang/MethodUtilsTest.java
> (with props)
> > Modified:
> >
>
commons/proper/lang/branches/LANG_POST_2_4/src/test/org/apache/commons/lang/LangTestSuite.java
>
>
---------------------------------------------------------------------
> To unsubscribe, e-mail:
> dev-unsubscribe@commons.apache.org
> For additional commands, e-mail:
> dev-help@commons.apache.org
>
>
____________________________________________________________________________________
Never miss a thing. Make Yahoo your home page.
http://www.yahoo.com/r/hs
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org