You are viewing a plain text version of this content. The canonical link for it is here.
Posted to modperl-cvs@perl.apache.org by ge...@apache.org on 2005/09/28 20:18:45 UTC
svn commit: r292234 - in /perl/modperl/trunk: Changes t/apache/constants.t
t/response/TestModules/proxy.pm xs/tables/current/Apache2/ConstantsTable.pm
Author: geoff
Date: Wed Sep 28 11:18:39 2005
New Revision: 292234
URL: http://svn.apache.org/viewcvs?rev=292234&view=rev
Log:
add :proxy import tag to Apache2::Const which exposes new
constants PROXYREQ_NONE, PROXYREQ_PROXY, and PROXYREQ_REVERSE
Modified:
perl/modperl/trunk/Changes
perl/modperl/trunk/t/apache/constants.t
perl/modperl/trunk/t/response/TestModules/proxy.pm
perl/modperl/trunk/xs/tables/current/Apache2/ConstantsTable.pm
Modified: perl/modperl/trunk/Changes
URL: http://svn.apache.org/viewcvs/perl/modperl/trunk/Changes?rev=292234&r1=292233&r2=292234&view=diff
==============================================================================
--- perl/modperl/trunk/Changes (original)
+++ perl/modperl/trunk/Changes Wed Sep 28 11:18:39 2005
@@ -12,6 +12,10 @@
=item 2.0.2-dev
+add :proxy import tag to Apache2::Const which exposes new
+constants PROXYREQ_NONE, PROXYREQ_PROXY, and PROXYREQ_REVERSE
+[Geoffrey Young]
+
$0 Fixes : [Gozer]
- Setting $0 works on Linux again
- HP-UX and *BSDes show the correct process name instead of '-e'
Modified: perl/modperl/trunk/t/apache/constants.t
URL: http://svn.apache.org/viewcvs/perl/modperl/trunk/t/apache/constants.t?rev=292234&r1=292233&r2=292234&view=diff
==============================================================================
--- perl/modperl/trunk/t/apache/constants.t (original)
+++ perl/modperl/trunk/t/apache/constants.t Wed Sep 28 11:18:39 2005
@@ -6,7 +6,7 @@
use Apache::TestUtil;
# -compile puts constants into the Apache2:: namespace
-use Apache2::Const -compile => qw(:http :common :mpmq
+use Apache2::Const -compile => qw(:http :common :mpmq :proxy
TAKE23 &OPT_EXECCGI
DECLINE_CMD DIR_MAGIC_TYPE
CRLF);
@@ -15,7 +15,7 @@
# caller namespace. also defaults to :common
use Apache2::Const;
-plan tests => 17;
+plan tests => 18;
ok t_cmp(REDIRECT, 302, 'REDIRECT');
@@ -36,6 +36,10 @@
ok t_cmp(Apache2::Const::MPMQ_MAX_SPARE_DAEMONS,
9,
'Apache2::Const::MPMQ_MAX_SPARE_DAEMONS');
+
+ok t_cmp(Apache2::Const::PROXYREQ_REVERSE,
+ 2,
+ 'Apache2::Const::PROXYREQ_REVERSE');
# the rest of the tests don't fit into the t_cmp() meme
# for one reason or anothre...
Modified: perl/modperl/trunk/t/response/TestModules/proxy.pm
URL: http://svn.apache.org/viewcvs/perl/modperl/trunk/t/response/TestModules/proxy.pm?rev=292234&r1=292233&r2=292234&view=diff
==============================================================================
--- perl/modperl/trunk/t/response/TestModules/proxy.pm (original)
+++ perl/modperl/trunk/t/response/TestModules/proxy.pm Wed Sep 28 11:18:39 2005
@@ -11,7 +11,7 @@
my $uri_real = "/TestModules__proxy_real";
-use Apache2::Const -compile => qw(DECLINED OK);
+use Apache2::Const -compile => qw(DECLINED OK PROXYREQ_REVERSE);
sub proxy {
my $r = shift;
@@ -23,7 +23,7 @@
my $real_url = sprintf "http://%s:%d%s",
$s->server_hostname, $s->port, $uri_real;
- $r->proxyreq(1);
+ $r->proxyreq(Apache2::Const::PROXYREQ_REVERSE);
$r->uri($real_url);
$r->filename("proxy:$real_url");
$r->handler('proxy-server');
Modified: perl/modperl/trunk/xs/tables/current/Apache2/ConstantsTable.pm
URL: http://svn.apache.org/viewcvs/perl/modperl/trunk/xs/tables/current/Apache2/ConstantsTable.pm?rev=292234&r1=292233&r2=292234&view=diff
==============================================================================
--- perl/modperl/trunk/xs/tables/current/Apache2/ConstantsTable.pm (original)
+++ perl/modperl/trunk/xs/tables/current/Apache2/ConstantsTable.pm Wed Sep 28 11:18:39 2005
@@ -227,7 +227,12 @@
'TAKE23',
'TAKE123',
'TAKE13'
- ]
+ ],
+ 'proxy' => [
+ 'PROXYREQ_REVERSE',
+ 'PROXYREQ_NONE',
+ 'PROXYREQ_PROXY',
+ ],
},
'APR::Const' => {
'uri' => [
@@ -459,7 +464,7 @@
],
'common' => [
'APR_SUCCESS'
- ]
+ ],
}
};
Re: svn commit: r292234 - in /perl/modperl/trunk: Changes t/apache/constants.t
t/response/TestModules/proxy.pm xs/tables/current/Apache2/ConstantsTable.pm
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
Stas Bekman wrote:
> Stas Bekman wrote:
>
>> geoff@apache.org wrote:
>>
>>> Author: geoff
>>> Date: Wed Sep 28 11:18:39 2005
>>> New Revision: 292234
>>>
>>> URL: http://svn.apache.org/viewcvs?rev=292234&view=rev
>>> Log:
>>> add :proxy import tag to Apache2::Const which exposes new
>>> constants PROXYREQ_NONE, PROXYREQ_PROXY, and PROXYREQ_REVERSE
>>
>>
>> any idea why the corresponding API documentation commit didn't make it
>> to the docs list?
>
>
> Geoff, this change is still not documented. What's the point of having
> the feature that nobody knows it exists? We spent all this time trying
> to bring the code in sync with docs, now that mp2 is released, we don't
> care anymore?
>
> Thank you.
yeah, I'm getting there...
--Geoff
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: svn commit: r292234 - in /perl/modperl/trunk: Changes t/apache/constants.t
t/response/TestModules/proxy.pm xs/tables/current/Apache2/ConstantsTable.pm
Posted by Stas Bekman <st...@stason.org>.
Stas Bekman wrote:
> geoff@apache.org wrote:
>
>> Author: geoff
>> Date: Wed Sep 28 11:18:39 2005
>> New Revision: 292234
>>
>> URL: http://svn.apache.org/viewcvs?rev=292234&view=rev
>> Log:
>> add :proxy import tag to Apache2::Const which exposes new
>> constants PROXYREQ_NONE, PROXYREQ_PROXY, and PROXYREQ_REVERSE
>
> any idea why the corresponding API documentation commit didn't make it
> to the docs list?
Geoff, this change is still not documented. What's the point of having the
feature that nobody knows it exists? We spent all this time trying to
bring the code in sync with docs, now that mp2 is released, we don't care
anymore?
Thank you.
>> Modified: perl/modperl/trunk/xs/tables/current/Apache2/ConstantsTable.pm
>> URL:
>> http://svn.apache.org/viewcvs/perl/modperl/trunk/xs/tables/current/Apache2/ConstantsTable.pm?rev=292234&r1=292233&r2=292234&view=diff
>>
>> ==============================================================================
>>
>> --- perl/modperl/trunk/xs/tables/current/Apache2/ConstantsTable.pm
>> (original)
>> +++ perl/modperl/trunk/xs/tables/current/Apache2/ConstantsTable.pm Wed
>> Sep 28 11:18:39 2005
>> @@ -227,7 +227,12 @@
>> 'TAKE23',
>> 'TAKE123',
>> 'TAKE13'
>> - ]
>> + ],
>> + 'proxy' => [
>> + 'PROXYREQ_REVERSE',
>> + 'PROXYREQ_NONE',
>> + 'PROXYREQ_PROXY',
>> + ],
--
_______________________________________________________________
Stas Bekman mailto:stas@stason.org | http://stason.org/
MailChannels: Assured Messaging (TM) | http://mailchannels.com/
The "Practical mod_perl" book | http://modperlbook.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: svn commit: r292234 - in /perl/modperl/trunk: Changes t/apache/constants.t
t/response/TestModules/proxy.pm xs/tables/current/Apache2/ConstantsTable.pm
Posted by Stas Bekman <st...@stason.org>.
geoff@apache.org wrote:
> Author: geoff
> Date: Wed Sep 28 11:18:39 2005
> New Revision: 292234
>
> URL: http://svn.apache.org/viewcvs?rev=292234&view=rev
> Log:
> add :proxy import tag to Apache2::Const which exposes new
> constants PROXYREQ_NONE, PROXYREQ_PROXY, and PROXYREQ_REVERSE
any idea why the corresponding API documentation commit didn't make it to
the docs list?
> Modified: perl/modperl/trunk/xs/tables/current/Apache2/ConstantsTable.pm
> URL: http://svn.apache.org/viewcvs/perl/modperl/trunk/xs/tables/current/Apache2/ConstantsTable.pm?rev=292234&r1=292233&r2=292234&view=diff
> ==============================================================================
> --- perl/modperl/trunk/xs/tables/current/Apache2/ConstantsTable.pm (original)
> +++ perl/modperl/trunk/xs/tables/current/Apache2/ConstantsTable.pm Wed Sep 28 11:18:39 2005
> @@ -227,7 +227,12 @@
> 'TAKE23',
> 'TAKE123',
> 'TAKE13'
> - ]
> + ],
> + 'proxy' => [
> + 'PROXYREQ_REVERSE',
> + 'PROXYREQ_NONE',
> + 'PROXYREQ_PROXY',
> + ],
> },
> 'APR::Const' => {
> 'uri' => [
> @@ -459,7 +464,7 @@
> ],
> 'common' => [
> 'APR_SUCCESS'
> - ]
> + ],
> }
> };
>
>
--
_______________________________________________________________
Stas Bekman mailto:stas@stason.org | http://stason.org/
MailChannels: Assured Messaging (TM) | http://mailchannels.com/
The "Practical mod_perl" book | http://modperlbook.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org