You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/03/09 01:16:01 UTC

[GitHub] [iotdb] neuyilan commented on a change in pull request #2778: [IOTDB-1186] Remove redundant sync meta leader in query process for cluster module

neuyilan commented on a change in pull request #2778:
URL: https://github.com/apache/iotdb/pull/2778#discussion_r589864270



##########
File path: cluster/src/main/java/org/apache/iotdb/cluster/ClusterMain.java
##########
@@ -260,7 +260,7 @@ private static void preStartCustomize() {
           @Override
           public int calculateSlotByTime(String storageGroupName, long timestamp, int maxSlotNum) {
             int sgSerialNum = extractSerialNumInSGName(storageGroupName) % k;
-            if (sgSerialNum > 0) {
+            if (sgSerialNum >= 0) {

Review comment:
       As long as k is not zero, we will not get the ArithmeticException / by zero error.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org