[GitHub] [hadoop] ayushtkn commented on a change in pull request #3655: HDFS-16321. Fix invalid config in TestAvailableSpaceRackFaultTolerantBPP

[GitBox <gi...@apache.org>]

ayushtkn commented on a change in pull request #3655:
URL: https://github.com/apache/hadoop/pull/3655#discussion_r748725737



##########
File path: hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestAvailableSpaceRackFaultTolerantBPP.java
##########
@@ -189,6 +189,13 @@ public void testChooseDataNode() {
     }
   }
 
+  @Test
+  public void testDefaultConfigValue() {
+    Assert.assertEquals(
+            conf.get("DFS_NAMENODE_AVAILABLE_SPACE_RACK_FAULT_TOLERANT_BLOCK_PLACEMENT_POLICY_BALANCED_SPACE_PREFERENCE_FRACTION_KEY")
+            ,0.6f);
+  }
+

Review comment:
       This isn't required, this isn't checking the BPP, but how the conf object works. you can remove this test.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org