You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "thinkharderdev (via GitHub)" <gi...@apache.org> on 2024/07/02 17:03:35 UTC
Re: [I] Cleanup Empty Directories in LocalFilesystem [arrow-rs]
thinkharderdev commented on issue #5976:
URL: https://github.com/apache/arrow-rs/issues/5976#issuecomment-2197022150
I'm perfectly fine with doing this internal to `LocalFilesystem` to minimize changes but to make the argument for the new method:
1. It is a useful shorthand for an operation that should be reasonably common even with non-filesystem implementations.
2. It can be formulated in terms of the default implementation of existing methods so won't break anything
3. Handling it internal to `LocalFilesystem` requires doing a bunch of unnecessary filesystem operations (and their associated syscalls) since we have to try and delete the parent directory after deleting each file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org