You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by as...@apache.org on 2007/02/23 16:41:28 UTC

svn commit: r510986 - in /incubator/qpid/branches/qpid.0-9: ./ cpp/lib/broker/BrokerChannel.cpp

Author: astitcher
Date: Fri Feb 23 07:41:28 2007
New Revision: 510986

URL: http://svn.apache.org/viewvc?view=rev&rev=510986
Log:
 r1237@fuschia:  andrew | 2007-02-23 15:40:44 +0000
 Bug in acks - Small typo fixed

Modified:
    incubator/qpid/branches/qpid.0-9/   (props changed)
    incubator/qpid/branches/qpid.0-9/cpp/lib/broker/BrokerChannel.cpp

Propchange: incubator/qpid/branches/qpid.0-9/
------------------------------------------------------------------------------
--- svk:merge (original)
+++ svk:merge Fri Feb 23 07:41:28 2007
@@ -1 +1 @@
-8427bd24-ae5a-4eba-a324-d2fc9c9c6c77:/local/qpid.0-9.ams:1224
+8427bd24-ae5a-4eba-a324-d2fc9c9c6c77:/local/qpid.0-9.ams:1237

Modified: incubator/qpid/branches/qpid.0-9/cpp/lib/broker/BrokerChannel.cpp
URL: http://svn.apache.org/viewvc/incubator/qpid/branches/qpid.0-9/cpp/lib/broker/BrokerChannel.cpp?view=diff&rev=510986&r1=510985&r2=510986
==============================================================================
--- incubator/qpid/branches/qpid.0-9/cpp/lib/broker/BrokerChannel.cpp (original)
+++ incubator/qpid/branches/qpid.0-9/cpp/lib/broker/BrokerChannel.cpp Fri Feb 23 07:41:28 2007
@@ -233,7 +233,6 @@
     }
 }
 
-// TODO astitcher 2007-02-08 This only deals correctly with non batched responses
 void Channel::ack(){
 	ack(getFirstAckRequest(), getLastAckRequest());
 }
@@ -248,8 +247,7 @@
 
 void Channel::ack(u_int64_t firstTag, u_int64_t lastTag){
     if(transactional){
-    	//FIXME astitcher This only works for Basic style acks
-        accumulatedAck.update(lastTag, lastTag);
+        accumulatedAck.update(firstTag, lastTag);
 
         //TODO: I think the outstanding prefetch size & count should be updated at this point...
         //TODO: ...this may then necessitate dispatching to consumers