You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/05 07:18:37 UTC

[GitHub] [arrow-datafusion] houqp edited a comment on pull request #605: fix join column handling logic for `On` and `Using` constraints

houqp edited a comment on pull request #605:
URL: https://github.com/apache/arrow-datafusion/pull/605#issuecomment-873534193


   @alamb reimplemented the logic based on your suggestion in https://github.com/apache/arrow-datafusion/pull/605#issuecomment-866862804.
   
   Turns out there are many more edge-cases that need to be handled for using join other than wildcard expansion:
   
   * predicate push down on join columns
   * normalize unqualified column expressions that reference join columns with qualifiers
   
   I have implemented support for all these edge-cases, but decided to leave out the wildcard expansion change as a follow up PR to keep the diff easier to review.
   
   UPDATE: filed https://github.com/apache/arrow-datafusion/pull/678 as follow up.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org