You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@vcl.apache.org by "Aaron Coburn (JIRA)" <ji...@apache.org> on 2012/09/07 18:54:07 UTC

[jira] [Created] (VCL-624) getUserlistID should be passed a user's full login string, not just a unityid

Aaron Coburn created VCL-624:
--------------------------------

             Summary: getUserlistID should be passed a user's full login string, not just a unityid
                 Key: VCL-624
                 URL: https://issues.apache.org/jira/browse/VCL-624
             Project: VCL
          Issue Type: Bug
          Components: web gui (frontend)
    Affects Versions: 2.3
            Reporter: Aaron Coburn
            Assignee: Aaron Coburn
            Priority: Minor
             Fix For: 2.4, 2.3.1


The utils.php:getUserlistID() function expects a loginid value, but there are places in the web code where it is being passed a unityid (i.e. the loginid stripped of an AFFILIATION) instead. There are also some naming conventions, such as in utils.php:addUserGroupMember() where the variables suggest the use of a $unityid, but in reality, these are $loginid values.

The only place where this is really an issue is in updateRequest() -- and then only if the system is using a custom set of findAffilFuncs that don't set a default affiliation. And there, the call to getUserlistID appears to be entirely superfluous.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (VCL-624) getUserlistID should be passed a user's full login string, not just a unityid

Posted by "Aaron Coburn (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/VCL-624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aaron Coburn resolved VCL-624.
------------------------------

    Resolution: Fixed
    
> getUserlistID should be passed a user's full login string, not just a unityid
> -----------------------------------------------------------------------------
>
>                 Key: VCL-624
>                 URL: https://issues.apache.org/jira/browse/VCL-624
>             Project: VCL
>          Issue Type: Bug
>          Components: web gui (frontend)
>    Affects Versions: 2.3
>            Reporter: Aaron Coburn
>            Assignee: Aaron Coburn
>            Priority: Minor
>             Fix For: 2.4, 2.3.1
>
>
> The utils.php:getUserlistID() function expects a loginid value, but there are places in the web code where it is being passed a unityid (i.e. the loginid stripped of an AFFILIATION) instead. There are also some naming conventions, such as in utils.php:addUserGroupMember() where the variables suggest the use of a $unityid, but in reality, these are $loginid values.
> The only place where this is really an issue is in updateRequest() -- and then only if the system is using a custom set of findAffilFuncs that don't set a default affiliation. And there, the call to getUserlistID appears to be entirely superfluous.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira