[GitHub] [flink] dmvk commented on a diff in pull request #22364: [FLINK-31744] Include JobVertex info in sparse EG

["dmvk (via GitHub)" <gi...@apache.org>]

dmvk commented on code in PR #22364:
URL: https://github.com/apache/flink/pull/22364#discussion_r1162427721


##########
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ArchivedExecutionGraph.java:
##########
@@ -362,8 +367,59 @@ public static ArchivedExecutionGraph createSparseArchivedExecutionGraph(
             @Nullable Throwable throwable,
             @Nullable JobCheckpointingSettings checkpointingSettings,
             long initializationTimestamp) {
+        return createSparseArchivedExecutionGraph(
+                jobId,
+                jobName,
+                jobStatus,
+                Collections.emptyList(),
+                throwable,
+                checkpointingSettings,
+                initializationTimestamp);
+    }
+
+    public static ArchivedExecutionGraph createSparseArchivedExecutionGraphWithJobVertices(
+            JobID jobId,
+            String jobName,
+            JobStatus jobStatus,
+            @Nullable Throwable throwable,
+            @Nullable JobCheckpointingSettings checkpointingSettings,
+            long initializationTimestamp,
+            Iterable<JobVertex> jobVertices,
+            VertexParallelismStore initialParallelismStore) {
+        List<ArchivedExecutionJobVertex> archivedVerticesInCreationOrder = new ArrayList<>();
+        for (JobVertex jobVertex : jobVertices) {
+            VertexParallelismInformation parallelismInfo =

Review Comment:
   
   
   
   
   nit:
   ```suggestion
           final List<ArchivedExecutionJobVertex> archivedVerticesInCreationOrder = new ArrayList<>();
           for (JobVertex jobVertex : jobVertices) {
               final VertexParallelismInformation parallelismInfo =
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org