You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/01/08 12:55:19 UTC
[GitHub] [skywalking-data-collect-protocol] arugal opened a new pull request
#11: Add field for browser perf service
arugal opened a new pull request #11: Add field for browser perf service
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/11
ref: [skywalking#4166](https://github.com/apache/skywalking/issues/4166)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-data-collect-protocol] arugal commented on a change in
pull request #11: Add field for browser perf service
Posted by GitBox <gi...@apache.org>.
arugal commented on a change in pull request #11: Add field for browser perf service
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/11#discussion_r364230912
##########
File path: browser/BrowserPerf.proto
##########
@@ -33,10 +33,14 @@ message BrowserPerfData {
int32 serviceId = 1;
// Service version in browser is the Instance concept in the backend.
int32 serviceVersionId = 2;
+ // Data time
+ int64 time = 3; // assignment by the backend
Review comment:
deleted
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-data-collect-protocol] wu-sheng commented on a change
in pull request #11: Add field for browser perf service
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #11: Add field for browser perf service
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/11#discussion_r364223549
##########
File path: browser/BrowserPerf.proto
##########
@@ -33,10 +33,14 @@ message BrowserPerfData {
int32 serviceId = 1;
// Service version in browser is the Instance concept in the backend.
int32 serviceVersionId = 2;
+ // Data time
+ int64 time = 3; // assignment by the backend
+ // Page path in browser is the endpoint concept in the backend
// Page path in the browser, mostly it is URI, without parameter
- string pagePath = 3;
- repeated BrowserErrorLog logs = 4;
- PerfDetail perfDetail = 5;
+ string pagePath = 4;
+ int32 pagePathId = 5; // assignment by the backend
Review comment:
Same here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-data-collect-protocol] wu-sheng merged pull request
#11: Add field for browser perf service
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #11: Add field for browser perf service
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/11
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-data-collect-protocol] wu-sheng commented on a change
in pull request #11: Add field for browser perf service
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #11: Add field for browser perf service
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/11#discussion_r364223617
##########
File path: browser/BrowserPerf.proto
##########
@@ -47,6 +51,8 @@ message BrowserErrorLog {
int32 col = 5;
string stack = 6;
string errorUrl = 7;
+ // Error log time
+ int64 time = 8; // assignment by the backend
Review comment:
Same here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-data-collect-protocol] wu-sheng commented on a change
in pull request #11: Add field for browser perf service
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #11: Add field for browser perf service
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/11#discussion_r364223497
##########
File path: browser/BrowserPerf.proto
##########
@@ -33,10 +33,14 @@ message BrowserPerfData {
int32 serviceId = 1;
// Service version in browser is the Instance concept in the backend.
int32 serviceVersionId = 2;
+ // Data time
+ int64 time = 3; // assignment by the backend
Review comment:
Please don't add `assignment by the backend`. This could be set by the client side, then backend doesn't need to set it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services