You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by venkat sairam <ve...@gmail.com> on 2017/03/24 17:25:48 UTC
Review Request 57914: upgrade frontend-maven-plugin to latest >= 1.3
to make use of ignore proxy feature
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57914/
-----------------------------------------------------------
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, and Rohit Choudhary.
Bugs: AMBARI-20549
https://issues.apache.org/jira/browse/AMBARI-20549
Repository: ambari
Description
-------
We have changed the path for node modules in pom.xml and package.json accordingly
Diffs
-----
contrib/views/capacity-scheduler/pom.xml f89bb8e
contrib/views/files/src/main/resources/ui/package.json d15c5c9
contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 6fe68e2
contrib/views/hive20/src/main/resources/ui/package.json 5c0da36
contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/package.json 64b3270
contrib/views/pig/pom.xml 7f0ade8
Diff: https://reviews.apache.org/r/57914/diff/1/
Testing
-------
Manual testing done
Thanks,
venkat sairam
Re: Review Request 57914: upgrade frontend-maven-plugin to latest >=
1.3 to make use of ignore proxy feature
Posted by Rohit Choudhary <rc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57914/#review170100
-----------------------------------------------------------
Ship it!
Ship It!
- Rohit Choudhary
On March 24, 2017, 5:25 p.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57914/
> -----------------------------------------------------------
>
> (Updated March 24, 2017, 5:25 p.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, and Rohit Choudhary.
>
>
> Bugs: AMBARI-20549
> https://issues.apache.org/jira/browse/AMBARI-20549
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We have changed the path for node modules in pom.xml and package.json accordingly
>
>
> Diffs
> -----
>
> contrib/views/capacity-scheduler/pom.xml f89bb8e
> contrib/views/files/src/main/resources/ui/package.json d15c5c9
> contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 6fe68e2
> contrib/views/hive20/src/main/resources/ui/package.json 5c0da36
> contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/package.json 64b3270
> contrib/views/pig/pom.xml 7f0ade8
>
>
> Diff: https://reviews.apache.org/r/57914/diff/1/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> Thanks,
>
> venkat sairam
>
>
Re: Review Request 57914: upgrade frontend-maven-plugin to latest >=
1.3 to make use of ignore proxy feature
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57914/#review170101
-----------------------------------------------------------
Ship it!
Ship It!
- Gaurav Nagar
On March 24, 2017, 5:25 p.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57914/
> -----------------------------------------------------------
>
> (Updated March 24, 2017, 5:25 p.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, and Rohit Choudhary.
>
>
> Bugs: AMBARI-20549
> https://issues.apache.org/jira/browse/AMBARI-20549
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We have changed the path for node modules in pom.xml and package.json accordingly
>
>
> Diffs
> -----
>
> contrib/views/capacity-scheduler/pom.xml f89bb8e
> contrib/views/files/src/main/resources/ui/package.json d15c5c9
> contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 6fe68e2
> contrib/views/hive20/src/main/resources/ui/package.json 5c0da36
> contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/package.json 64b3270
> contrib/views/pig/pom.xml 7f0ade8
>
>
> Diff: https://reviews.apache.org/r/57914/diff/1/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> Thanks,
>
> venkat sairam
>
>
Re: Review Request 57914: upgrade frontend-maven-plugin to latest >=
1.3 to make use of ignore proxy feature
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57914/#review170118
-----------------------------------------------------------
This patch causes views unit tests to fail:
[INFO] npm ERR! argv "/Users/Jaimin/vagrant/ambari-vagrant/centos6.4/ambari/contrib/views/files/src/main/resources/ui/node/node" "/Users/Jaimin/vagrant/ambari-vagrant/centos6.4/ambari/contrib/views/files/src/main/resources/ui/node/npm/bin/npm-cli.js" "install" "--python=\"/Users/Jaimin/vagrant/ambari-vagrant/centos6.4/ambari/contrib/views/files/../src/main/unix/ambari-python-wrap\"" "--unsafe-perm" "--color=false"
[INFO] npm ERR! node v4.5.0
[INFO] npm ERR! npm v2.15.0
[INFO] npm ERR! code ELIFECYCLE
[INFO] npm ERR! files-view@0.0.0 preinstall: `chmod +x node/node_modules/npm/bin/node-gyp-bin/node-gyp`
[INFO] npm ERR! Exit status 1
[INFO] npm ERR!
[INFO] npm ERR! Failed at the files-view@0.0.0 preinstall script 'chmod +x node/node_modules/npm/bin/node-gyp-bin/node-gyp'.
[INFO] npm ERR! This is most likely a problem with the files-view package,
[INFO] npm ERR! not with npm itself.
[INFO] npm ERR! Tell the author that this fails on your system:
[INFO] npm ERR! chmod +x node/node_modules/npm/bin/node-gyp-bin/node-gyp
[INFO] npm ERR! You can get information on how to open an issue for this project with:
[INFO] npm ERR! npm bugs files-view
[INFO] npm ERR! Or if that isn't available, you can get their info via:
[INFO] npm ERR!
[INFO] npm ERR! npm owner ls files-view
[INFO] npm ERR! There is likely additional logging output above.
[INFO]
[INFO] npm ERR! Please include the following file with any support request:
[INFO] npm ERR! /Users/Jaimin/vagrant/ambari-vagrant/centos6.4/ambari/contrib/views/files/src/main/resources/ui/npm-debug.log
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Contrib Views ............................... SUCCESS [01:07 min]
[INFO] Ambari View Utils .................................. SUCCESS [ 13.821 s]
[INFO] Ambari View Commons ................................ SUCCESS [ 0.505 s]
[INFO] Files .............................................. FAILURE [ 9.725 s]
[INFO] Jobs ............................................... SKIPPED
[INFO] Pig ................................................ SKIPPED
- Jaimin Jetly
On March 24, 2017, 5:25 p.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57914/
> -----------------------------------------------------------
>
> (Updated March 24, 2017, 5:25 p.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, and Rohit Choudhary.
>
>
> Bugs: AMBARI-20549
> https://issues.apache.org/jira/browse/AMBARI-20549
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We have changed the path for node modules in pom.xml and package.json accordingly
>
>
> Diffs
> -----
>
> contrib/views/capacity-scheduler/pom.xml f89bb8e
> contrib/views/files/src/main/resources/ui/package.json d15c5c9
> contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 6fe68e2
> contrib/views/hive20/src/main/resources/ui/package.json 5c0da36
> contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/package.json 64b3270
> contrib/views/pig/pom.xml 7f0ade8
>
>
> Diff: https://reviews.apache.org/r/57914/diff/1/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> Thanks,
>
> venkat sairam
>
>
Re: Review Request 57914: upgrade frontend-maven-plugin to latest >=
1.3 to make use of ignore proxy feature
Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57914/#review170120
-----------------------------------------------------------
Ship it!
Ship It!
- Pallav Kulshreshtha
On March 26, 2017, 7:05 p.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57914/
> -----------------------------------------------------------
>
> (Updated March 26, 2017, 7:05 p.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, and Rohit Choudhary.
>
>
> Bugs: AMBARI-20549
> https://issues.apache.org/jira/browse/AMBARI-20549
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We have changed the path for node modules in pom.xml and package.json accordingly
>
>
> Diffs
> -----
>
> contrib/views/capacity-scheduler/pom.xml b8c4dae
> contrib/views/files/pom.xml b075ec7
> contrib/views/hawq/pom.xml 2aa04e0
> contrib/views/hive-next/pom.xml 50563ac
> contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 5c5435e
> contrib/views/hive20/pom.xml e672b3f
> contrib/views/hive20/src/main/resources/ui/package.json 98c465f
> contrib/views/hueambarimigration/pom.xml f131b3b
> contrib/views/jobs/pom.xml d58ce10
> contrib/views/pig/pom.xml 689909f
> contrib/views/wfmanager/pom.xml 69784e3
> contrib/views/wfmanager/src/main/resources/ui/pom.xml 8bdb332
>
>
> Diff: https://reviews.apache.org/r/57914/diff/2/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> Thanks,
>
> venkat sairam
>
>
Re: Review Request 57914: upgrade frontend-maven-plugin to latest >=
1.3 to make use of ignore proxy feature
Posted by venkat sairam <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57914/
-----------------------------------------------------------
(Updated March 26, 2017, 7:05 p.m.)
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, and Rohit Choudhary.
Bugs: AMBARI-20549
https://issues.apache.org/jira/browse/AMBARI-20549
Repository: ambari
Description
-------
We have changed the path for node modules in pom.xml and package.json accordingly
Diffs (updated)
-----
contrib/views/capacity-scheduler/pom.xml b8c4dae
contrib/views/files/pom.xml b075ec7
contrib/views/hawq/pom.xml 2aa04e0
contrib/views/hive-next/pom.xml 50563ac
contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 5c5435e
contrib/views/hive20/pom.xml e672b3f
contrib/views/hive20/src/main/resources/ui/package.json 98c465f
contrib/views/hueambarimigration/pom.xml f131b3b
contrib/views/jobs/pom.xml d58ce10
contrib/views/pig/pom.xml 689909f
contrib/views/wfmanager/pom.xml 69784e3
contrib/views/wfmanager/src/main/resources/ui/pom.xml 8bdb332
Diff: https://reviews.apache.org/r/57914/diff/2/
Changes: https://reviews.apache.org/r/57914/diff/1-2/
Testing
-------
Manual testing done
Thanks,
venkat sairam