You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by mmartell <gi...@git.apache.org> on 2017/02/04 19:30:50 UTC
[GitHub] geode pull request #391: GEODE-2422: Switch remaining GemFire strings to Geo...
GitHub user mmartell opened a pull request:
https://github.com/apache/geode/pull/391
GEODE-2422: Switch remaining GemFire strings to Geode.
- includes rename GemFireCache.hpp to GeodeCache.hpp
- GemFire, Gemfire, and gemfire replaced with Geode, Geode, geode
- includes only source changes: .cs, .cpp, and .hpp
- doesn't include guard statement changes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mmartell/geode feature/GEODE-2422
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/391.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #391
----
commit c6b7d55022fbc7111b93447430d984b95896e688
Author: Mike Martell <mm...@pivotal.io>
Date: 2017-02-04T19:22:38Z
GEODE-2422: Switch remaining GemFire strings to Geode.
- includes rename GemFireCache.hpp to GeodeCache.hpp
- GemFire, Gemfire, and gemfire replaced with Geode, Geode, geode
- includes only source changes: .cs, .cpp, and .hpp
- doesn't include guard statement changes
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #391: GEODE-2422: Switch remaining GemFire strings to Geode.
Posted by echobravopapa <gi...@git.apache.org>.
Github user echobravopapa commented on the issue:
https://github.com/apache/geode/pull/391
Conflicts are removed. ready for Merge!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #391: GEODE-2422: Switch remaining GemFire strings to Geo...
Posted by echobravopapa <gi...@git.apache.org>.
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode/pull/391#discussion_r100191415
--- Diff: src/clicache/integration-test/CacheHelperN.cs ---
@@ -2389,7 +2389,7 @@ public static void KillJavaProcesses()
string commandline = item["CommandLine"].ToString();
Util.Log("processId:{0} name:{1}", item["ProcessId"], item["Name"]);
- if (commandline.Contains("geode.jar"))
+ if (commandline.Contains("gemfire.jar"))
--- End diff --
We have a story to remove this as is unused.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #391: GEODE-2422: Switch remaining GemFire strings to Geode.
Posted by echobravopapa <gi...@git.apache.org>.
Github user echobravopapa commented on the issue:
https://github.com/apache/geode/pull/391
We should have separate stories/jiras for those items.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #391: GEODE-2422: Switch remaining GemFire strings to Geode.
Posted by echobravopapa <gi...@git.apache.org>.
Github user echobravopapa commented on the issue:
https://github.com/apache/geode/pull/391
@metatype in fact, we do have separate stories for the rest.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #391: GEODE-2422: Switch remaining GemFire strings to Geode.
Posted by metatype <gi...@git.apache.org>.
Github user metatype commented on the issue:
https://github.com/apache/geode/pull/391
LGTM. There are still references to Pivotal, GemStone, and copyright stuff that should be cleaned up.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #391: GEODE-2422: Switch remaining GemFire strings to Geo...
Posted by mmartell <gi...@git.apache.org>.
Github user mmartell closed the pull request at:
https://github.com/apache/geode/pull/391
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] geode pull request #391: GEODE-2422: Switch remaining
GemFire strings to Geo...
Posted by Michael William Dodge <md...@pivotal.io>.
I filed a separate JIRA for this as there is no geode.jar and KillJavaProcesses() will not work correctly.
> On 8 Feb, 2017, at 14:47, dgkimura <gi...@git.apache.org> wrote:
>
> Github user dgkimura commented on a diff in the pull request:
>
> https://github.com/apache/geode/pull/391#discussion_r100191055
>
> --- Diff: src/clicache/integration-test/CacheHelperN.cs ---
> @@ -2389,7 +2389,7 @@ public static void KillJavaProcesses()
> string commandline = item["CommandLine"].ToString();
>
> Util.Log("processId:{0} name:{1}", item["ProcessId"], item["Name"]);
> - if (commandline.Contains("geode.jar"))
> + if (commandline.Contains("gemfire.jar"))
> --- End diff --
>
> I'm curious why this one you're switching geode with gemfire. What makes this one different?
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
[GitHub] geode pull request #391: GEODE-2422: Switch remaining GemFire strings to Geo...
Posted by dgkimura <gi...@git.apache.org>.
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode/pull/391#discussion_r100191055
--- Diff: src/clicache/integration-test/CacheHelperN.cs ---
@@ -2389,7 +2389,7 @@ public static void KillJavaProcesses()
string commandline = item["CommandLine"].ToString();
Util.Log("processId:{0} name:{1}", item["ProcessId"], item["Name"]);
- if (commandline.Contains("geode.jar"))
+ if (commandline.Contains("gemfire.jar"))
--- End diff --
I'm curious why this one you're switching geode with gemfire. What makes this one different?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #391: GEODE-2422: Switch remaining GemFire strings to Geode.
Posted by PivotalSarge <gi...@git.apache.org>.
Github user PivotalSarge commented on the issue:
https://github.com/apache/geode/pull/391
Done. GEODE-2348
> On 6 Feb, 2017, at 14:29, Michael Martell <no...@github.com> wrote:
>
> Good catch that must not be used. So we should remove it. Please create a new ticket for that.
>
> \u2014
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub <https://github.com/apache/geode/pull/391#issuecomment-277835333>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ATlz4ufwOp5iV_f4FjWW1flVqHllf3Utks5rZ57OgaJpZM4L3QYi>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #391: GEODE-2422: Switch remaining GemFire strings to Geode.
Posted by mmartell <gi...@git.apache.org>.
Github user mmartell commented on the issue:
https://github.com/apache/geode/pull/391
Good catch that must not be used. So we should remove it. Please create a new ticket for that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #391: GEODE-2422: Switch remaining GemFire strings to Geode.
Posted by mmartell <gi...@git.apache.org>.
Github user mmartell commented on the issue:
https://github.com/apache/geode/pull/391
This closes #391.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---