[jira] [Commented] (NUTCH-1274) Fix [cast] javac warnings

["Lewis John McGibbney (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NUTCH-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13551791#comment-13551791 ] 

Lewis John McGibbney commented on NUTCH-1274:
---------------------------------------------

Hi Tejas. The trunk patch does not fully address all [cast] flags. SOme still exist in the following classes
Webgraph @line 348
ContextAsTextInputFormat @ 52, 53
SegmentMerger @ 216
SegmentReader @240
FreeGenerator @127
ArcRecordReader @125, 132, 267, 269
TestParserFactory @52, 54, 56
If you wish to address these then please do, I'll also have a trawl through the 2.x patch just now.
Thank you for your contributions.
                
> Fix [cast] javac warnings
> -------------------------
>
>                 Key: NUTCH-1274
>                 URL: https://issues.apache.org/jira/browse/NUTCH-1274
>             Project: Nutch
>          Issue Type: Sub-task
>          Components: build
>    Affects Versions: nutchgora, 1.5
>            Reporter: Lewis John McGibbney
>            Priority: Minor
>             Fix For: 1.7
>
>         Attachments: NUTCH-1274-2.x.patch, NUTCH-1274-trunk.patch
>
>
> A typical example of this is
> {code}
> trunk/src/java/org/apache/nutch/crawl/CrawlDatum.java:460: warning: [cast] redundant cast to int
>     [javac]         res ^= (int)(signature[i] << 24 + signature[i+1] << 16 + 
> {code}
> these should all be fixed by replacing with the correct implementations.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira