You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "DaWesen (via GitHub)" <gi...@apache.org> on 2026/08/18 07:56:11 UTC
[PR] chore: add doc comments and unit tests for instance customizers [dubbo-go]
DaWesen opened a new pull request, #3676:
URL: https://github.com/apache/dubbo-go/pull/3676
### Description
This PR improves the comments and test coverage of the service discovery instance customizers.
- Adds doc comments to hostPortCustomizer, tagCustomizer, and the exported/subscribed revision customizers, explaining how host/port, tag, and revision affect the instance info registered to the registry.
- Fixes the wrong Customize comment in service_instance_host_port_customizer.go (was copied from the revision customizer).
- Adds unit tests for host/port writing covering: port already set, nil service metadata, no exported URLs, first-URL-only, unparsable port, and non-DefaultServiceInstance.
Refs `https://github.com/apache/dubbo-go/issues/3644` (task5)
### 本地验证
```
~/project/dubbo-go$ go test ./registry/servicediscovery/customizer/...
ok dubbo.apache.org/dubbo-go/v3/registry/servicediscovery/customizer (cached)
```
### Checklist
- [x] I confirm the target branch is `develop`
- [x] Code has passed local testing
- [x] I have added tests that prove my fix is effective or that my feature works
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] chore: add doc comments and unit tests for instance customizers [dubbo-go]
Posted by "Alanxtl (via GitHub)" <gi...@apache.org>.
Alanxtl merged PR #3676:
URL: https://github.com/apache/dubbo-go/pull/3676
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] chore: add doc comments and unit tests for instance customizers [dubbo-go]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #3676:
URL: https://github.com/apache/dubbo-go/pull/3676#issuecomment-5325284734
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3676) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3676&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3676&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=3676&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3676&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3676&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3676)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] chore: add doc comments and unit tests for instance customizers [dubbo-go]
Posted by "DaWesen (via GitHub)" <gi...@apache.org>.
DaWesen commented on PR #3676:
URL: https://github.com/apache/dubbo-go/pull/3676#issuecomment-5325775338
@Alanxtl PTAL when you have a moment. All checks have passed. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] chore: add doc comments and unit tests for instance customizers [dubbo-go]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3676:
URL: https://github.com/apache/dubbo-go/pull/3676#issuecomment-5325502625
## [Codecov](https://app.codecov.io/gh/apache/dubbo-go/pull/3676?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 54.84%. Comparing base ([`8409492`](https://app.codecov.io/gh/apache/dubbo-go/commit/840949261ff9a9b771631422542bc9b134b7ff0c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`dafaddd`](https://app.codecov.io/gh/apache/dubbo-go/commit/dafaddd38f6077b3ff497063657a67a98da96c23?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 11 commits behind head on develop.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #3676 +/- ##
===========================================
+ Coverage 54.69% 54.84% +0.15%
===========================================
Files 474 475 +1
Lines 36701 36796 +95
===========================================
+ Hits 20073 20182 +109
+ Misses 15006 15001 -5
+ Partials 1622 1613 -9
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/dubbo-go/pull/3676?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org