[jira] [Comment Edited] (CXF-6307) Wrong select the message body reader

["Neal Hu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CXF-6307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14383520#comment-14383520 ] 

Neal Hu edited comment on CXF-6307 at 3/27/15 8:37 AM:
-------------------------------------------------------

Sorry, I have shorted the case. The original one is typed on Object too:
@Override
public Object readFrom(Class<Boolean> type,
Type type1,
Annotation[] antns,
MediaType mt, MultivaluedMap<String, String> mm,
InputStream in) throws IOException, WebApplicationException
{ return Boolean.valueOf("true");// the original case will invoke one method and return the Boolean type here }
}

The key point here is the spec mentioned the pre-packaged provided provider ONLY support text/plain, and the application's provider supports \*/\*. So the  pre-packaged  MUST be chosen. I went through the CXF code and found the provider lack of text/plain. What's more CXF matchs Application provided providers first(in this case the text/plain matches \*/\* and skip to match the  pre-packaged providered, even when explicit text/plain on  pre-packaged).

If my understanding is incorrect please advise. Thanks.


was (Author: xingjhu@cn.ibm.com):
Sorry, I have shorted the case. The original one is typed on Object too:
@Override
public Object readFrom(Class<Boolean> type,
Type type1,
Annotation[] antns,
MediaType mt, MultivaluedMap<String, String> mm,
InputStream in) throws IOException, WebApplicationException
{ return Boolean.valueOf("true");// the original case will invoke one method and return the Boolean type here }
}

The key point here is the spec mentioned the pre-packaged provided provider ONLY support text/plain, and the application's provider supports /*//*. So the  pre-packaged  MUST be chosen. I went through the CXF code and found the provider lack of text/plain. What's more CXF matchs Application provided providers first(in this case the text/plain matches /*//* and skip to match the  pre-packaged providered, even when explicit text/plain on  pre-packaged).

If my understanding is incorrect please advise. Thanks.

> Wrong select the message body reader
> ------------------------------------
>
>                 Key: CXF-6307
>                 URL: https://issues.apache.org/jira/browse/CXF-6307
>             Project: CXF
>          Issue Type: Bug
>          Components: JAX-RS
>    Affects Versions: 3.0.3
>         Environment: Windows
>            Reporter: Neal Hu
>             Fix For: 3.0.5
>
>
> This is a CTS testcase, the resource class is like this:   
>    @POST
>     @Path("boolean")
>     public Boolean postBoolean(Boolean bool) {
>     	if(bool){    		 
>     		throw new WebApplicationException(Status.NOT_ACCEPTABLE);
>     	}
>         return false;
>     }
> The application provided provider is like this:
> public class MyReader implements MessageBodyReader<Boolean> {
>     @Override
>     public boolean isReadable(Class<?> type, Type type1, Annotation[] antns, MediaType mt) {
>     	return type== Boolean.class;
>     }
>     @Override
>     public Boolean readFrom(Class<Boolean> type,
>                              Type type1,
>                              Annotation[] antns,
>                              MediaType mt, MultivaluedMap<String, String> mm,
>                              InputStream in) throws IOException, WebApplicationException {
> 		return Boolean.valueOf("true");        
>     }
> }
> The request
> Content-Type:text/plain
> Accept:text/plain 
> Method:POST
> Body:false
> According to jsr339 section 4.2.4 Standard Entity Providers java.lang.Boolean, java.lang.Character, java.lang.Number Only for text/plain. Corresponding primitive types supported via boxing/unboxing conversion.
> An implementation MUST support application-provided entity providers and MUST use those in preference to its own pre-packaged providers when either could handle the same request. More precisely, step 4 in Section 4.2.1 and step 5 in Section 4.2.2 MUST prefer application-provided over pre-packaged entity providers.
> 4.2.1 Message Body Reader
> 3. Select the set of MessageBodyReader classes that support the media type of the request, see Section
> 4.2.3.
> 4. Iterate through the selected MessageBodyReader classes and, utilizing the isReadable method of
> each, choose a MessageBodyReader provider that supports the desired Java type.
> It says the entity providers should be sorted by media type firstly then(the media type is the same) on Section 4.2.1 and step 5 in Section 4.2.2 MUST prefer application-provided over pre-packaged entity providers. So org.apache.cxf.jaxrs.provider.PrimitiveTextProvider should be selected as its media type MUST be text/plain and the application provider's media type is */*.(x/y>x/*>*/*)
> So at this point the CTS expected response code is 200 instead of 406, the application provided provider should not be chosen.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)