You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by "Digy (JIRA)" <ji...@apache.org> on 2007/08/21 22:20:30 UTC

[jira] Created: (LUCENENET-82) NUnite test for TestSimpleExplanations

NUnite test for TestSimpleExplanations
--------------------------------------

                 Key: LUCENENET-82
                 URL: https://issues.apache.org/jira/browse/LUCENENET-82
             Project: Lucene.Net
          Issue Type: Bug
            Reporter: Digy
            Priority: Minor
         Attachments: MultiPhraseQuery.patch, QueryUtils.patch

1- 
   a- MultiPhraseQuery.Equals method fails because of invalid type casting       ( Term item1 = (Term) iter1.Current; ===> Term[] item1 = (Term[]) iter1.Current; ). 
   b- When comparing two Term-arrays, the values  should be compared, not the instances of them.

2- QueryUtil.CheckUnequal should compare two queries, not the equality of the instances.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (LUCENENET-82) NUnite test for TestSimpleExplanations

Posted by "George Aroush (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENENET-82?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

George Aroush resolved LUCENENET-82.
------------------------------------

    Resolution: Fixed

I used this patch to apply the fix, but with the following additional changes (to consolidate the fix with an earlier fix):
1) Removed SupportClass.cs from Test
2) Added CompareTermArrays() to SupportClass.cs of Lucene.Net,, and
3) Moved CompareStringArrays() to SupportClass.cs of Lucene.Net

> NUnite test for TestSimpleExplanations
> --------------------------------------
>
>                 Key: LUCENENET-82
>                 URL: https://issues.apache.org/jira/browse/LUCENENET-82
>             Project: Lucene.Net
>          Issue Type: Bug
>            Reporter: Digy
>            Assignee: George Aroush
>            Priority: Minor
>         Attachments: MultiPhraseQuery.patch, QueryUtils.patch
>
>
> 1- 
>    a- MultiPhraseQuery.Equals method fails because of invalid type casting       ( Term item1 = (Term) iter1.Current; ===> Term[] item1 = (Term[]) iter1.Current; ). 
>    b- When comparing two Term-arrays, the values  should be compared, not the instances of them.
> 2- QueryUtil.CheckUnequal should compare two queries, not the equality of the instances.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (LUCENENET-82) NUnite test for TestSimpleExplanations

Posted by "Digy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENENET-82?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Digy updated LUCENENET-82:
--------------------------

    Attachment: MultiPhraseQuery.patch

> NUnite test for TestSimpleExplanations
> --------------------------------------
>
>                 Key: LUCENENET-82
>                 URL: https://issues.apache.org/jira/browse/LUCENENET-82
>             Project: Lucene.Net
>          Issue Type: Bug
>            Reporter: Digy
>            Priority: Minor
>         Attachments: MultiPhraseQuery.patch, QueryUtils.patch
>
>
> 1- 
>    a- MultiPhraseQuery.Equals method fails because of invalid type casting       ( Term item1 = (Term) iter1.Current; ===> Term[] item1 = (Term[]) iter1.Current; ). 
>    b- When comparing two Term-arrays, the values  should be compared, not the instances of them.
> 2- QueryUtil.CheckUnequal should compare two queries, not the equality of the instances.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (LUCENENET-82) NUnite test for TestSimpleExplanations

Posted by "George Aroush (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENENET-82?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

George Aroush closed LUCENENET-82.
----------------------------------


> NUnite test for TestSimpleExplanations
> --------------------------------------
>
>                 Key: LUCENENET-82
>                 URL: https://issues.apache.org/jira/browse/LUCENENET-82
>             Project: Lucene.Net
>          Issue Type: Bug
>            Reporter: Digy
>            Assignee: George Aroush
>            Priority: Minor
>         Attachments: MultiPhraseQuery.patch, QueryUtils.patch
>
>
> 1- 
>    a- MultiPhraseQuery.Equals method fails because of invalid type casting       ( Term item1 = (Term) iter1.Current; ===> Term[] item1 = (Term[]) iter1.Current; ). 
>    b- When comparing two Term-arrays, the values  should be compared, not the instances of them.
> 2- QueryUtil.CheckUnequal should compare two queries, not the equality of the instances.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (LUCENENET-82) NUnite test for TestSimpleExplanations

Posted by "Digy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENENET-82?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Digy updated LUCENENET-82:
--------------------------

    Attachment: QueryUtils.patch

> NUnite test for TestSimpleExplanations
> --------------------------------------
>
>                 Key: LUCENENET-82
>                 URL: https://issues.apache.org/jira/browse/LUCENENET-82
>             Project: Lucene.Net
>          Issue Type: Bug
>            Reporter: Digy
>            Priority: Minor
>         Attachments: MultiPhraseQuery.patch, QueryUtils.patch
>
>
> 1- 
>    a- MultiPhraseQuery.Equals method fails because of invalid type casting       ( Term item1 = (Term) iter1.Current; ===> Term[] item1 = (Term[]) iter1.Current; ). 
>    b- When comparing two Term-arrays, the values  should be compared, not the instances of them.
> 2- QueryUtil.CheckUnequal should compare two queries, not the equality of the instances.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (LUCENENET-82) NUnite test for TestSimpleExplanations

Posted by "George Aroush (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENENET-82?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

George Aroush reassigned LUCENENET-82:
--------------------------------------

    Assignee: George Aroush

> NUnite test for TestSimpleExplanations
> --------------------------------------
>
>                 Key: LUCENENET-82
>                 URL: https://issues.apache.org/jira/browse/LUCENENET-82
>             Project: Lucene.Net
>          Issue Type: Bug
>            Reporter: Digy
>            Assignee: George Aroush
>            Priority: Minor
>         Attachments: MultiPhraseQuery.patch, QueryUtils.patch
>
>
> 1- 
>    a- MultiPhraseQuery.Equals method fails because of invalid type casting       ( Term item1 = (Term) iter1.Current; ===> Term[] item1 = (Term[]) iter1.Current; ). 
>    b- When comparing two Term-arrays, the values  should be compared, not the instances of them.
> 2- QueryUtil.CheckUnequal should compare two queries, not the equality of the instances.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.