[GitHub] [accumulo] brianloss commented on a change in pull request #1907: Rename Master to Manager in class names.

[GitBox <gi...@apache.org>]

brianloss commented on a change in pull request #1907:
URL: https://github.com/apache/accumulo/pull/1907#discussion_r570267039



##########
File path: test/src/main/java/org/apache/accumulo/test/start/KeywordStartIT.java
##########
@@ -162,7 +163,7 @@ public void checkHasMain() {
     expectSet.add(Info.class);
     expectSet.add(Initialize.class);
     expectSet.add(LoginProperties.class);
-    expectSet.add(Master.class);
+    expectSet.add(Manager.class);

Review comment:
       ManagerExecutable and MasterExecutable (deprecated) both exist, but their execute methods both call Manager.main. But you're saying I should add an empty deprecated Master (in the old package) that extends Manager but has a main method in case a user invoked directly instead of via the accumulo scripts?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org