You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Gregory Shimansky (JIRA)" <ji...@apache.org> on 2006/06/25 20:41:29 UTC
[jira] Created: (HARMONY-655) [drlvm] Patch to DRLVM to work with
unmodified bootclasspath.properties from classlib
[drlvm] Patch to DRLVM to work with unmodified bootclasspath.properties from classlib
-------------------------------------------------------------------------------------
Key: HARMONY-655
URL: http://issues.apache.org/jira/browse/HARMONY-655
Project: Harmony
Type: Bug
Components: VM
Reporter: Gregory Shimansky
Priority: Minor
The patch adds kernel.jar to the beginning of the bootclasspath and then adds everything from bootclasspath.[0-9] property lines in bootclasspath.properties file. All other lines should be ignored.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-655) [drlvm] Patch to DRLVM to work with
unmodified bootclasspath.properties from classlib
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-655?page=comments#action_12418265 ]
Mark Hindess commented on HARMONY-655:
--------------------------------------
Applied the second patch in r417798. Let me know if we missed anything.
I'll leave the test in this jira unless you particularly want me to commit it. (If you do just say where you'd like it to go.)
> [drlvm] Patch to DRLVM to work with unmodified bootclasspath.properties from classlib
> -------------------------------------------------------------------------------------
>
> Key: HARMONY-655
> URL: http://issues.apache.org/jira/browse/HARMONY-655
> Project: Harmony
> Type: Bug
> Components: VM
> Reporter: Gregory Shimansky
> Assignee: Mark Hindess
> Priority: Minor
> Attachments: Prop.java, kernel-jar-2.patch, kernel-jar-2.patch, kernel-jar.patch, kernel-jar.patch
>
> The patch adds kernel.jar to the beginning of the bootclasspath and then adds everything from bootclasspath.[0-9] property lines in bootclasspath.properties file. All other lines should be ignored.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-655) [drlvm] Patch to DRLVM to work with
unmodified bootclasspath.properties from classlib
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-655?page=all ]
Mark Hindess resolved HARMONY-655:
----------------------------------
Resolution: Fixed
Applied in r417676. Please confirm that this has been applied as expected.
> [drlvm] Patch to DRLVM to work with unmodified bootclasspath.properties from classlib
> -------------------------------------------------------------------------------------
>
> Key: HARMONY-655
> URL: http://issues.apache.org/jira/browse/HARMONY-655
> Project: Harmony
> Type: Bug
> Components: VM
> Reporter: Gregory Shimansky
> Assignee: Mark Hindess
> Priority: Minor
> Attachments: kernel-jar.patch, kernel-jar.patch
>
> The patch adds kernel.jar to the beginning of the bootclasspath and then adds everything from bootclasspath.[0-9] property lines in bootclasspath.properties file. All other lines should be ignored.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-655) [drlvm] Patch to DRLVM to work with
unmodified bootclasspath.properties from classlib
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-655?page=all ]
Mark Hindess reassigned HARMONY-655:
------------------------------------
Assign To: Mark Hindess
> [drlvm] Patch to DRLVM to work with unmodified bootclasspath.properties from classlib
> -------------------------------------------------------------------------------------
>
> Key: HARMONY-655
> URL: http://issues.apache.org/jira/browse/HARMONY-655
> Project: Harmony
> Type: Bug
> Components: VM
> Reporter: Gregory Shimansky
> Assignee: Mark Hindess
> Priority: Minor
> Attachments: kernel-jar.patch, kernel-jar.patch
>
> The patch adds kernel.jar to the beginning of the bootclasspath and then adds everything from bootclasspath.[0-9] property lines in bootclasspath.properties file. All other lines should be ignored.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-655) [drlvm] Patch to DRLVM to work with
unmodified bootclasspath.properties from classlib
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-655?page=all ]
Mark Hindess closed HARMONY-655:
--------------------------------
Verified by Gregory.
> [drlvm] Patch to DRLVM to work with unmodified bootclasspath.properties from classlib
> -------------------------------------------------------------------------------------
>
> Key: HARMONY-655
> URL: http://issues.apache.org/jira/browse/HARMONY-655
> Project: Harmony
> Type: Bug
> Components: VM
> Reporter: Gregory Shimansky
> Assignee: Mark Hindess
> Priority: Minor
> Attachments: Prop.java, kernel-jar-2.patch, kernel-jar-2.patch, kernel-jar.patch, kernel-jar.patch
>
> The patch adds kernel.jar to the beginning of the bootclasspath and then adds everything from bootclasspath.[0-9] property lines in bootclasspath.properties file. All other lines should be ignored.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-655) [drlvm] Patch to DRLVM to work with
unmodified bootclasspath.properties from classlib
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-655?page=all ]
Gregory Shimansky updated HARMONY-655:
--------------------------------------
Attachment: kernel-jar.patch
I've changed the patch a bit to remove too agressive assertion and make it more stable with syntax mistakes. Use this verion of the patch.
> [drlvm] Patch to DRLVM to work with unmodified bootclasspath.properties from classlib
> -------------------------------------------------------------------------------------
>
> Key: HARMONY-655
> URL: http://issues.apache.org/jira/browse/HARMONY-655
> Project: Harmony
> Type: Bug
> Components: VM
> Reporter: Gregory Shimansky
> Priority: Minor
> Attachments: kernel-jar.patch, kernel-jar.patch
>
> The patch adds kernel.jar to the beginning of the bootclasspath and then adds everything from bootclasspath.[0-9] property lines in bootclasspath.properties file. All other lines should be ignored.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-655) [drlvm] Patch to DRLVM to work with
unmodified bootclasspath.properties from classlib
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-655?page=all ]
Gregory Shimansky updated HARMONY-655:
--------------------------------------
Attachment: Prop.java
Test which I used to verify how properties are set up.
> [drlvm] Patch to DRLVM to work with unmodified bootclasspath.properties from classlib
> -------------------------------------------------------------------------------------
>
> Key: HARMONY-655
> URL: http://issues.apache.org/jira/browse/HARMONY-655
> Project: Harmony
> Type: Bug
> Components: VM
> Reporter: Gregory Shimansky
> Assignee: Mark Hindess
> Priority: Minor
> Attachments: Prop.java, kernel-jar-2.patch, kernel-jar-2.patch, kernel-jar.patch, kernel-jar.patch
>
> The patch adds kernel.jar to the beginning of the bootclasspath and then adds everything from bootclasspath.[0-9] property lines in bootclasspath.properties file. All other lines should be ignored.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-655) [drlvm] Patch to DRLVM to work with
unmodified bootclasspath.properties from classlib
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-655?page=all ]
Gregory Shimansky updated HARMONY-655:
--------------------------------------
Attachment: kernel-jar-2.patch
Hello Mark
Everything is ok in what you've applied except for my patch itself :)
I've just realized that there are two redundant lines for checking char_pos pointer to NULL. It is a leftover from the version where I used strchr. Now it cannot be NULL and checking it makes no sense. Please apply the 2nd patch to remove these two lines.
> [drlvm] Patch to DRLVM to work with unmodified bootclasspath.properties from classlib
> -------------------------------------------------------------------------------------
>
> Key: HARMONY-655
> URL: http://issues.apache.org/jira/browse/HARMONY-655
> Project: Harmony
> Type: Bug
> Components: VM
> Reporter: Gregory Shimansky
> Assignee: Mark Hindess
> Priority: Minor
> Attachments: kernel-jar-2.patch, kernel-jar.patch, kernel-jar.patch
>
> The patch adds kernel.jar to the beginning of the bootclasspath and then adds everything from bootclasspath.[0-9] property lines in bootclasspath.properties file. All other lines should be ignored.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-655) [drlvm] Patch to DRLVM to work with
unmodified bootclasspath.properties from classlib
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-655?page=all ]
Gregory Shimansky updated HARMONY-655:
--------------------------------------
Attachment: kernel-jar.patch
> [drlvm] Patch to DRLVM to work with unmodified bootclasspath.properties from classlib
> -------------------------------------------------------------------------------------
>
> Key: HARMONY-655
> URL: http://issues.apache.org/jira/browse/HARMONY-655
> Project: Harmony
> Type: Bug
> Components: VM
> Reporter: Gregory Shimansky
> Priority: Minor
> Attachments: kernel-jar.patch
>
> The patch adds kernel.jar to the beginning of the bootclasspath and then adds everything from bootclasspath.[0-9] property lines in bootclasspath.properties file. All other lines should be ignored.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-655) [drlvm] Patch to DRLVM to work with
unmodified bootclasspath.properties from classlib
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-655?page=comments#action_12418272 ]
Gregory Shimansky commented on HARMONY-655:
-------------------------------------------
Thank you, the patch is applied correctly.
> [drlvm] Patch to DRLVM to work with unmodified bootclasspath.properties from classlib
> -------------------------------------------------------------------------------------
>
> Key: HARMONY-655
> URL: http://issues.apache.org/jira/browse/HARMONY-655
> Project: Harmony
> Type: Bug
> Components: VM
> Reporter: Gregory Shimansky
> Assignee: Mark Hindess
> Priority: Minor
> Attachments: Prop.java, kernel-jar-2.patch, kernel-jar-2.patch, kernel-jar.patch, kernel-jar.patch
>
> The patch adds kernel.jar to the beginning of the bootclasspath and then adds everything from bootclasspath.[0-9] property lines in bootclasspath.properties file. All other lines should be ignored.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-655) [drlvm] Patch to DRLVM to work with
unmodified bootclasspath.properties from classlib
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-655?page=all ]
Gregory Shimansky updated HARMONY-655:
--------------------------------------
Attachment: kernel-jar-2.patch
Sorry for inconvenience, I've found out I forgot to check for dot after bootclasspath word. This is the updated version of the 2nd patch.
> [drlvm] Patch to DRLVM to work with unmodified bootclasspath.properties from classlib
> -------------------------------------------------------------------------------------
>
> Key: HARMONY-655
> URL: http://issues.apache.org/jira/browse/HARMONY-655
> Project: Harmony
> Type: Bug
> Components: VM
> Reporter: Gregory Shimansky
> Assignee: Mark Hindess
> Priority: Minor
> Attachments: kernel-jar-2.patch, kernel-jar-2.patch, kernel-jar.patch, kernel-jar.patch
>
> The patch adds kernel.jar to the beginning of the bootclasspath and then adds everything from bootclasspath.[0-9] property lines in bootclasspath.properties file. All other lines should be ignored.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira